Upgrade to Ruby 2.4 #16101
Upgrade to Ruby 2.4 #16101
Conversation
|
Checked commits chrisarcand/manageiq@632ec2f~...0f7d65d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -1,4 +1,4 @@ | |||
| raise "Ruby versions less than 2.2.2 are unsupported!" if RUBY_VERSION < "2.2.2" | |||
| raise "Ruby versions less than 2.3.5 are unsupported!" if RUBY_VERSION < "2.3.5" | |||
There was a problem hiding this comment.
@jrafanie Is this...ok? Sanity check.
There was a problem hiding this comment.
No, I think this needs to be < 2.3.1 since the oldest 2.3 will be on downstream appliances with the 2.3.1 package cc @simaishi (for confirmation)
There was a problem hiding this comment.
Right, 2.3.1 needs to stay as the supported version until downstream appliances get newer ruby.
|
We also have a ruby in our container-httpd, which we're going to have to ensure matches: https://github.com/ManageIQ/container-httpd/blob/master/Dockerfile#L78-L79 |
| @@ -123,7 +123,7 @@ ADD . ${APP_ROOT} | |||
|
|
|||
| ## Setup environment | |||
| RUN ${APPLIANCE_ROOT}/setup && \ | |||
| echo "export PATH=\$PATH:/opt/rubies/ruby-2.3.1/bin" >> /etc/default/evm && \ | |||
| echo "export PATH=\$PATH:/opt/rubies/ruby-2.4.2/bin" >> /etc/default/evm && \ | |||
There was a problem hiding this comment.
Can you extract the Docker changes into a separate PR (same reasons as I stated in ManageIQ/manageiq-appliance-build#229 (comment) ). This way we can merge that separately from the Travis/Gemfile bump.
|
Closing this, some things need to be split up with these changes actually. |
To be merged on Wednesday, October 4th
Updates our stuff to use Ruby 2.4.2
Part of #14446