Adding custom attributes to provider (UI + API)

[alongoldboim]

New view

Added a new api endpoint:
url: http://localhost:3000/api/providers/3/custom_attributes
method: Post

Request.payload:

{
    "action": "add/edit/delete",
    "resources": [{
        "name": "exp_date",
        "value": "1.2.2016",
        "field_type": "Date"
    }, {
        "name": "expected_num_of_nodes",
        "value": 2
    }, {
        "name": "sales_force_acount",
        "value": "ADF231VRWQ1"
    }]
}

[alongoldboim]

depends on: #10896

[Fryguy]

Please don't mix unrelated rubocops in the same PR and the feature itself (i.e. these freezes).

[alongoldboim]

Removed.

[Fryguy]

So, I think we already have methods for adding and removing custom attributes (perhaps not via the REST API). I'm not sure why we need to re-add that under a new name of "meta data" cc @gmcculloug I think you've done this before, right?

[Fryguy]

This is an N+1. I think you can query all of the requisite attributes up front (or just query them all)

[Fryguy]

an action name of "meta_data" by itself is very strange. Since it does a full replacement (but no deletes?) I would expect an action word in the front like "update_metadata"

Also,

• metadata is a single word, so shouldn't be broken up
• even so (as mentioned above) I think it should say custom_attributes to be consistent with usages in the UI.

[Fryguy]

Sorry, one more thing...we also have the concept of different types of custom_attributes as handled by the "source" column. So ManageIQ can have it's own custom_attributes which I think uses the MIQ source, and the EMS can have theirs which I think is the EMS source, with possibilities of other sources. I think you might want to limit which source you want to show in the UI. Again, I believe this is handled on the VMs screen, but possibly others...I'd have to check to be sure

[gmcculloug]

You can see this on the VM screen by editing any VM in the UI and setting the Custom Identifier field to value.

It will show up in the Custom Attributes section of the VM Summary screen as custom_1

[imtayadeway]

@abellotti If I understood correctly I think this action is supported in current implementation?

Are there tests to support that?

[alongoldboim]

@abellotti fixed minor comments, @imtayadeway Yes the current tests are supporting add/edit/delete.
@gtanzillo @Loicavenel Think this one can get merged if there are no more comments.

[alongoldboim]

@miq-bot add_label euwe/yes

[abellotti]

Hi @alongoldboim thanks for the updates. could you take of the rubocop warnings ? Thanks.

[gtanzillo]

👍 LGTM. Will merge once the rubocops are addressed.

[miq-bot]

Checked commits alongoldboim/manageiq@66b37e3~...e406e78 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 0 offenses detected
Everything looks good. ⭐

[alongoldboim]

@gtanzillo Rubocop is happy now.

[chessbyte]

Euwe Backport details:

$ git log
commit a16aedc889a2bec9e37a2530b530f46483b31d33
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Oct 6 11:08:03 2016 -0400

    Merge pull request #10897 from alongoldboim/provider_meta_data

    Adding custom attributes to provider (UI + API)
    (cherry picked from commit 46277eefa4ea925a2607628c7815fbc5a8f214c0)