Allow ui classic to run CI in act #9327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additionally removes the jasmine overrides that we had for Travis, but are no longer necessary in GitHub Actions and act
Fryguy
commented
Jan 14, 2025
| @@ -21,6 +21,10 @@ if [ -n "$ACT" ]; then | |||
| curl -o- -L https://yarnpkg.com/install.sh | bash | |||
| echo "$HOME/.yarn/bin" >> $GITHUB_PATH | |||
| echo "$HOME/.config/yarn/global/node_modules/.bin" >> $GITHUB_PATH | |||
|
|
|||
| # Install cmake so we can build rugged gem | |||
| sudo apt-get install -y cmake | |||
There was a problem hiding this comment.
Note that the core repo's before_install already does this: https://github.com/ManageIQ/manageiq/blob/5f3f33dc811fc007ad07a5a6a42cc8cfe79ad3f7/bin/before_install#L18-L20
I'd really like to get something like ManageIQ/manageiq-providers-amazon#744 working, but for now this is required.
GilbertCherrie
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally removes the jasmine overrides that we had for Travis, but are no longer necessary in GitHub Actions and act
@GilbertCherrie Please review. This PR will allow you to run the jquery PR locally and have it fail. After this PR is merged, rebase your PR and run the following: