Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter vms displayed in tree lan #8998

Merged
merged 2 commits into from
Jan 9, 2024
Merged

filter vms displayed in tree lan #8998

merged 2 commits into from
Jan 9, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Dec 12, 2023

only display vms that are visible to customers

Before

host_network_before

After

host_network_after

@kbrock kbrock requested a review from a team as a code owner December 12, 2023 14:04
@kbrock
filter vms displayed in tree lan
cfabbe7 
only display vms that are visible to customers
@kbrock kbrock force-pushed the network_vms branch 2 times, most recently from bc9c515 to 72b6bf8 Compare January 4, 2024 03:51
@kbrock
Copy link
Member Author

kbrock commented Jan 4, 2024

update:

  • add rbac filtering on lans and guest devices (was already filtering vms)

update:

  • added rbac filtering to switches

update:

  • changed respond_to?(String) to symbol (rubocop)

@kbrock
Filter visible switches, lans, guest devices, and vms in the network …
491e2d4 
…tree

This adds filtering by tag for network lans, switches, and guest devices
And adds filtering by tag and tenant for vms

(changing rbac.filtered will add filtering by tenant for lans and others)
@kbrock
Copy link
Member Author

kbrock commented Jan 8, 2024

updated:

  • removed byebug that was commented out

@jeffibm yes, this is ready to go

@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2024

Checked commits kbrock/manageiq-ui-classic@cfabbe7~...491e2d4 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@jeffibm jeffibm merged commit 325850d into ManageIQ:master Jan 9, 2024
8 checks passed
@kbrock kbrock deleted the network_vms branch January 16, 2024 15:45
@Fryguy
Copy link
Member

Fryguy commented Jan 23, 2024

Backported to morphy in commit 6aa2cf4.

commit 6aa2cf4aa9c57dcb47e2f06213861f0d10650705
Author: Jeffrey Bonson <[email protected]>
Date:   Tue Jan 9 09:29:10 2024 +0530

    Merge pull request #8998 from kbrock/network_vms
    
    filter vms displayed in tree lan
    
    (cherry picked from commit 325850d8c975a3b1cf72229e62c38f1cec50e1e1)

Fryguy pushed a commit that referenced this pull request Jan 23, 2024
@jeffibm @Fryguy
Merge pull request #8998 from kbrock/network_vms
6aa2cf4 
filter vms displayed in tree lan

(cherry picked from commit 325850d)
@kbrock kbrock mentioned this pull request Jan 24, 2024
Merged
@Fryguy
Copy link
Member

Fryguy commented Jan 31, 2024

Backported to quinteros in commit b7bc3f4.

commit b7bc3f49d2ce6bafe28e5e47a6ec7b45d6168e6d
Author: Jeffrey Bonson <[email protected]>
Date:   Tue Jan 9 09:29:10 2024 +0530

    Merge pull request #8998 from kbrock/network_vms
    
    filter vms displayed in tree lan
    
    (cherry picked from commit 325850d8c975a3b1cf72229e62c38f1cec50e1e1)

Fryguy pushed a commit that referenced this pull request Jan 31, 2024
@jeffibm @Fryguy
Merge pull request #8998 from kbrock/network_vms
b7bc3f4 
filter vms displayed in tree lan

(cherry picked from commit 325850d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffibm jeffibm jeffibm approved these changes

Assignees

@Fryguy Fryguy

Labels
bug morphy/backported quinteros/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbrock @miq-bot @Fryguy @jeffibm