Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for responsive styles for layout and summary #8985

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Dec 5, 2023

This PR is about fixing the styles across the page when we change the browser width.

The style for the summary (MiqStructuredList component) contents are also affected with the changes.

Note: To test this, check out the branch clear the browser cache, and give in some time for the changes to take effect.

Window width: 555px

  1. Services / My Services / [ServiceItem] / Summary
    Before
    image
    After
    image

  2. Services / Catalogs / Service Catalogs / [Item] / [Item] / Summary
    Before
    image
    After
    image

Window width: 900px

  1. Automation / Embedded Automate / Workflows / [Item] / Summary
    Before
    image
    After
    image

  2. Services / Catalogs / Service Catalogs / [Item] / [Item] / Summary
    Before
    image
    After
    image

@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2023

Checked commit jeffbonson@bc9e6a4 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 13 offenses detected

app/views/layouts/_center_div_with_listnav.html.haml

  • 💣 💥 🔥 🚒 - Line 15 - Do not repeat id "#main-content" on the page
  • 💣 💥 🔥 🚒 - Line 38 - Do not repeat id "#main-content" on the page
  • ⚠️ - Line 12 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 12 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 12 - Line is too long. [104/80]
  • ⚠️ - Line 34 - Line is too long. [103/80]

app/views/layouts/_content.html.haml

  • 💣 💥 🔥 🚒 - Line 15 - Do not repeat id "#left_div" on the page
  • 💣 💥 🔥 🚒 - Line 16 - Do not repeat id "#default_left_cell" on the page
  • 💣 💥 🔥 🚒 - Line 19 - Do not repeat id "#left_div" on the page
  • 💣 💥 🔥 🚒 - Line 20 - Do not repeat id "#default_left_cell" on the page
  • ⚠️ - Line 25 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 25 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 25 - Line is too long. [151/80]

@jeffibm jeffibm changed the title Fix for responsive styles Fix for responsive styles for layout and summary Dec 5, 2023
@GilbertCherrie GilbertCherrie merged commit 50f48ae into ManageIQ:master Dec 7, 2023
8 checks passed
@Fryguy
Copy link
Member

Fryguy commented Dec 11, 2023

Backported to quinteros in commit c10490b.

commit c10490bbcc2d4c2ea0b105de90687b0af9795fae
Author: Gilbert Cherrie <[email protected]>
Date:   Thu Dec 7 15:52:39 2023 -0500

    Merge pull request #8985 from jeffibm/fix-responsive-styles-1
    
    Fix for responsive styles for layout and summary
    
    (cherry picked from commit 50f48ae2af0f154ad74ed5957ab502231f8af2a2)

Fryguy pushed a commit that referenced this pull request Dec 11, 2023
Fix for responsive styles for layout and summary

(cherry picked from commit 50f48ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants