Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade carbon packages to release 10.59.17 #8984

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Dec 4, 2023

Upgraded Carbon Components React to 7.59.17. Also upgraded dependent packages React, React-dom, eslint-plugin-jsx-a11y and stylelint.

This upgrade is required in order to fix Accessibility violations with the Data Table component.

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner December 4, 2023 19:05
@jeffibm jeffibm requested a review from DavidResende0 December 5, 2023 05:33
@GilbertCherrie GilbertCherrie changed the title Upgrade carbon components react to 7.59.17 Upgrade carbon packages to release 10.59.17 Dec 7, 2023
@GilbertCherrie GilbertCherrie force-pushed the upgrade_react branch 2 times, most recently from 326b455 to dc2c38b Compare December 7, 2023 21:09
@jeffibm
Copy link
Member

jeffibm commented Dec 8, 2023

@GilbertCherrie , Could you please resolve the conflicts?

@miq-bot
Copy link
Member

miq-bot commented Dec 14, 2023

Checked commit GilbertCherrie@84f78d5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidResende0 Please review.

@Fryguy Fryguy assigned DavidResende0 and unassigned jeffibm Dec 14, 2023
@jrafanie jrafanie merged commit 978a9e1 into ManageIQ:master Dec 18, 2023
8 checks passed
@GilbertCherrie GilbertCherrie deleted the upgrade_react branch December 18, 2023 17:03
@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

@GilbertCherrie A conflict occurred during the backport of this pull request to quinteros.

If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the quinteros branch in order to resolve this.

Conflict details:

diff --cc yarn.lock
index 4c5237e652,39ead9c227..0000000000
--- a/yarn.lock
+++ b/yarn.lock
@@@ -1258,12 -1259,12 +1258,18 @@@ __metadata
    languageName: node
    linkType: hard
  
++<<<<<<< HEAD
 +"@babel/runtime@npm:^7.1.2, @babel/runtime@npm:^7.10.0, @babel/runtime@npm:^7.10.2, @babel/runtime@npm:^7.12.1, @babel/runtime@npm:^7.15.4, @babel/runtime@npm:^7.16.7, @babel/runtime@npm:^7.19.4, @babel/runtime@npm:^7.3.1, @babel/runtime@npm:^7.6.3, @babel/runtime@npm:^7.8.3, @babel/runtime@npm:^7.8.4, @babel/runtime@npm:^7.9.1, @babel/runtime@npm:^7.9.2":
 +  version: 7.23.5
 +  resolution: "@babel/runtime@npm:7.23.5"
++=======
+ "@babel/runtime@npm:^7.1.2, @babel/runtime@npm:^7.10.0, @babel/runtime@npm:^7.10.2, @babel/runtime@npm:^7.11.2, @babel/runtime@npm:^7.12.1, @babel/runtime@npm:^7.15.4, @babel/runtime@npm:^7.16.7, @babel/runtime@npm:^7.19.4, @babel/runtime@npm:^7.3.1, @babel/runtime@npm:^7.6.3, @babel/runtime@npm:^7.8.3, @babel/runtime@npm:^7.8.4, @babel/runtime@npm:^7.9.1, @babel/runtime@npm:^7.9.2":
+   version: 7.23.6
+   resolution: "@babel/runtime@npm:7.23.6"
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    dependencies:
      regenerator-runtime: "npm:^0.14.0"
 -  checksum: 4c4ab16f0361c59fb23956e4d0a29935f1f8a64aa8dd37876ce38355b6f4d8f0e54237aacb89c73b1532def60539ddde2d651523c8fa887b30b19a8cf0c465b0
 +  checksum: 0f1669f639af30a0a2948ffcefa2c61935f337b0777bd94f8d7bc66bba8e7d4499e725caeb0449540d9c6d67399b733c4e719babb43ce9a0f33095aa01b42b37
    languageName: node
    linkType: hard
  
@@@ -2612,13 -2601,13 +2606,22 @@@
    linkType: hard
  
  "@types/react@npm:*, @types/react@npm:>=16.9.11":
++<<<<<<< HEAD
 +  version: 18.2.42
 +  resolution: "@types/react@npm:18.2.42"
++=======
+   version: 18.2.45
+   resolution: "@types/react@npm:18.2.45"
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    dependencies:
      "@types/prop-types": "npm:*"
      "@types/scheduler": "npm:*"
      csstype: "npm:^3.0.2"
++<<<<<<< HEAD
 +  checksum: b6ee1873ba551ca7bf87cefff00a615aa4322cd68d425858a2e09be260d8037d7fc68865739d2b05cc88cefa7acd009afdaea43e9856fc6302b322cc8c19464e
++=======
+   checksum: bd27fd8a959fa776965997af89cb04e43e7868416850fdff421b5539f389efa35acae3d55915c9f32d7b00fb388550302bf8a7f06010abf9ad431e5bf58cb774
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    languageName: node
    linkType: hard
  
@@@ -4707,9 -4696,9 +4710,15 @@@
    linkType: hard
  
  "caniuse-lite@npm:^1.0.30000981, caniuse-lite@npm:^1.0.30001109, caniuse-lite@npm:^1.0.30001565":
++<<<<<<< HEAD
 +  version: 1.0.30001566
 +  resolution: "caniuse-lite@npm:1.0.30001566"
 +  checksum: fdff43ed498201bf4f6074bd1112bd853e91973b6ccb016049b030948a7d197cba235ac4d93e712d1862b33a3c947bf4e62bad7011ccdac78e5179501b28d04a
++=======
+   version: 1.0.30001570
+   resolution: "caniuse-lite@npm:1.0.30001570"
+   checksum: a9b939e003dd70580cc18bce54627af84f298af7c774415c8d6c99871e7cee13bd8278b67955a979cd338369c73e8821a10b37e607d1fff2fbc8ff92fc489653
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    languageName: node
    linkType: hard
  
@@@ -6761,9 -6769,9 +6789,15 @@@
    linkType: hard
  
  "electron-to-chromium@npm:^1.4.601":
++<<<<<<< HEAD
 +  version: 1.4.607
 +  resolution: "electron-to-chromium@npm:1.4.607"
 +  checksum: 3670335ae7c65a4dd70e3fdf94de9ef8c8d66c3b55551ddd951e39a3ad1d2af0f04f014c1df969e67632c1198ccba8bece1629302a083b043b826ac13abb3d3c
++=======
+   version: 1.4.612
+   resolution: "electron-to-chromium@npm:1.4.612"
+   checksum: 3c7c09d778e68aa161637a934dc1466fb87385ab3b964fd96399dfb8701c7fbe1ab1576cc25f02a2f8c618b2c4d8800379fdd29f121735e59277e67a4e783fab
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    languageName: node
    linkType: hard
  
@@@ -18288,8 -18277,8 +18303,13 @@@
    linkType: hard
  
  "ws@npm:^8.4.2":
++<<<<<<< HEAD
 +  version: 8.14.2
 +  resolution: "ws@npm:8.14.2"
++=======
+   version: 8.15.1
+   resolution: "ws@npm:8.15.1"
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    peerDependencies:
      bufferutil: ^4.0.1
      utf-8-validate: ">=5.0.2"
@@@ -18298,7 -18287,7 +18318,11 @@@
        optional: true
      utf-8-validate:
        optional: true
++<<<<<<< HEAD
 +  checksum: 815ff01d9bc20a249b2228825d9739268a03a4408c2e0b14d49b0e2ae89d7f10847e813b587ba26992bdc33e9d03bed131e4cae73ff996baf789d53e99c31186
++=======
+   checksum: 746a3102d43e8df7b09f5814bec858f12d10185a7abd655537f3291b687d440bb80fc9d1e082f8dee42d4d74307f78a96810e18a2c8e13053b003c6608c1c648
++>>>>>>> 978a9e1ae9 (Merge pull request #8984 from GilbertCherrie/upgrade_react)
    languageName: node
    linkType: hard
  

@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

Backported to quinteros in commit 4252add.

commit 4252add0631daa96ac87cd71a8776de0f1371303
Author: Joe Rafaniello <[email protected]>
Date:   Mon Dec 18 12:00:56 2023 -0500

    Merge pull request #8984 from GilbertCherrie/upgrade_react
    
    Upgrade carbon packages to release 10.59.17
    
    (cherry picked from commit 978a9e1ae96bd95bd0b94c84e3952966beba808f)

Fryguy pushed a commit that referenced this pull request Jan 5, 2024
Upgrade carbon packages to release 10.59.17

(cherry picked from commit 978a9e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants