Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect settings tab aria-labelledby id #8983

Merged

Conversation

GilbertCherrie
Copy link
Member

Fix incorrect settings tab aria-labelledby id caused by this pr: #8956

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2023

Checked commit GilbertCherrie@5fcf49f with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 3 offenses detected

app/views/configuration/_ui_4.html.haml

  • ⚠️ - Line 2 - Avoid using instance variables in partials views
  • ⚠️ - Line 2 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 2 - Hash attribute should start with one space after the opening brace

@jeffibm jeffibm merged commit 69e42a5 into ManageIQ:master Dec 5, 2023
8 checks passed
@GilbertCherrie GilbertCherrie deleted the fix_settings_tabs_aria_label branch December 5, 2023 14:16
@GilbertCherrie GilbertCherrie restored the fix_settings_tabs_aria_label branch December 5, 2023 14:16
@GilbertCherrie GilbertCherrie deleted the fix_settings_tabs_aria_label branch December 5, 2023 14:16
@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

Skipping backport to quinteros, because it is already in the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants