Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utilization accessibility issues #8982

Merged

Conversation

GilbertCherrie
Copy link
Member

Fix accessibility violations in the Accessibility Assessment Scanner for the Overview > Utilization page. The last remaining violation is due to the explorer tree and will exist until the explorer screens are removed.

Before:
Screenshot 2023-12-01 at 1 49 11 PM
Screenshot 2023-12-01 at 1 49 29 PM
Screenshot 2023-12-01 at 1 49 45 PM

After:
Screenshot 2023-12-01 at 1 43 56 PM
Screenshot 2023-12-01 at 1 44 36 PM
Screenshot 2023-12-01 at 1 45 25 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner December 1, 2023 18:49
@GilbertCherrie GilbertCherrie assigned jeffibm and unassigned jeffibm Dec 1, 2023
@GilbertCherrie GilbertCherrie force-pushed the fix_utilization_accessibility_issues branch from a871875 to 91917a9 Compare December 1, 2023 18:51
@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2023

Checked commit GilbertCherrie@91917a9 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 23 offenses detected

app/views/layouts/_perf_charts.html.haml

  • ⚠️ - Line 1 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 1 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 1 - Line is too long. [132/80]

app/views/utilization/_utilization_options.html.haml

  • ⚠️ - Line 13 - Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
  • ⚠️ - Line 13 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 14 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 21 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 21 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 27 - Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
  • ⚠️ - Line 27 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 28 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 35 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 35 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 3 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 3 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 3 - Line is too long. [137/80]
  • ⚠️ - Line 47 - Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line.
  • ⚠️ - Line 47 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 48 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 55 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 55 - Hash attribute should start with one space after the opening brace
  • ⚠️ - Line 8 - Hash attribute should end with one space before the closing brace or be on its own line
  • ⚠️ - Line 8 - Hash attribute should start with one space after the opening brace

@jeffibm jeffibm merged commit 2bff7b5 into ManageIQ:master Dec 6, 2023
@GilbertCherrie GilbertCherrie deleted the fix_utilization_accessibility_issues branch December 6, 2023 14:47
@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

Skipping backport to quinteros, because it is already in the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants