Fix my settings error screen #8980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
fix_settings_no_tabs_error
branch
from
bcedb7c to
27bd958
Compare
GilbertCherrie
force-pushed
the
fix_settings_no_tabs_error
branch
from
27bd958 to
6effc1a
Compare
|
Checked commit GilbertCherrie@6effc1a with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
DavidResende0
approved these changes
Nov 29, 2023
|
Skipping backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8979
Before an error screen is displayed when a user without any Modify permissions for Settings > My Settings visits the My Settings page. Now we display a blank screen instead. This is by design since without any Modify permissions no tabs will be rendered.
Before:
After:
