Default Disk Unit Fix in VM Reconfigure Form #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidResende0
force-pushed
the
vm-reconfigure-disk-fix
branch
from
05a0e20 to
414ce13
Compare
|
Hey @DavidResende0, the specs are failing. |
|
the spec failures are there in other branches as well |
DavidResende0
force-pushed
the
vm-reconfigure-disk-fix
branch
from
414ce13 to
8b98458
Compare
|
Checked commit DavidResende0@8b98458 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jeffibm
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to add a new disk in the VM reconfigure form, the default values for the Unit and Bootable fields were incorrectly being set to empty strings. This meant that if the user never directly changed these fields it would only look like they were setting them to
GBandfalserespectively.Later when submitting the form, these blank values would be set to defaults by the api, which was causing "GB" to be changed to "MB" in the reconfigure request.
This change fixes this.