Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating the CodeMirror into MiqStructuredList component. #8918

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Integrating the CodeMirror into MiqStructuredList component. #8918

merged 1 commit into from
Nov 23, 2023

Conversation

jeffibm
Copy link
Member

@jeffibm jeffibm commented Sep 12, 2023 •
edited
Loading

Integrate the CodeMirror component in the MiqStructuredList component.

Note: Edit page will remain the same.

Before
Screenshot 2023-11-21 at 10 34 24 AM

After
image

@jeffibm jeffibm requested a review from a team as a code owner September 12, 2023 14:02
@miq-bot miq-bot added the wip label Sep 12, 2023
@jeffibm jeffibm changed the title [WIP] Automate buildin and data summary conversion [WIP] Automate built-in and data summary conversion Nov 6, 2023
@jeffibm jeffibm force-pushed the automate-builtin-summary-conversion branch 4 times, most recently from 4e9f816 to adea9ff Compare November 21, 2023 05:02
@jeffibm jeffibm changed the title [WIP] Automate built-in and data summary conversion Integrating the CodeMirror into MiqStructuredList component. Nov 21, 2023
@miq-bot miq-bot removed the wip label Nov 21, 2023
@jeffibm jeffibm force-pushed the automate-builtin-summary-conversion branch 2 times, most recently from e16588b to 77ee7e4 Compare November 21, 2023 05:22
@jeffibm jeffibm force-pushed the automate-builtin-summary-conversion branch from 0d38e45 to e451f90 Compare November 21, 2023 06:32
@jeffibm jeffibm force-pushed the automate-builtin-summary-conversion branch from 9c7cb76 to c0f415c Compare November 21, 2023 06:51
@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2023

Checked commit jeffbonson@c0f415c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 17 offenses detected

app/views/miq_ae_class/_method_inputs.html.haml

  • ⚠️ - Line 16 - Avoid using instance variables in partials views
  • ⚠️ - Line 17 - Avoid using instance variables in partials views
  • ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 24 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 24 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 24 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 24 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 24 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 24 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 24 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 24 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
  • ⚠️ - Line 30 - Avoid using instance variables in partials views

@Fryguy
Copy link
Member

Fryguy commented Nov 22, 2023

Cool looks great!

@Fryguy Fryguy removed their assignment Nov 22, 2023
@GilbertCherrie GilbertCherrie merged commit e66d730 into ManageIQ:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GilbertCherrie GilbertCherrie GilbertCherrie approved these changes

@DavidResende0 DavidResende0 DavidResende0 approved these changes

Assignees

@DavidResende0 DavidResende0

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffibm @miq-bot @Fryguy @GilbertCherrie @DavidResende0