[ops_controller/settings/zones.rb] Soft delete auth #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLaMuro
force-pushed
the
soft-delete-zone-authentications
branch
from
4c2ac31 to
386138b
Compare
NickLaMuro
added a commit
to NickLaMuro/manageiq-documentation
that referenced
this pull request
Mar 3, 2021
This is to be paired with ManageIQ/manageiq-ui-classic#7650 which will remove this feature from the UI.
|
Probably better to allow users to run Ansible playbooks to do this and other things on Windows systems. See https://galaxy.ansible.com/ansible/windows |
7 tasks
|
Is this in a good state, or does more need to be done here? |
|
@kbrock good on my end, just waiting for approval from someone. |
|
@NickLaMuro could you please put before and after screenshots? |
|
@kavyanekkalapu oh, sure thing. |
Removes Auth from both the form, and the controller in the UI. Still allows them to be added via that `rails console`, but removes the feature from the UI, with the intent to possibly remove from the product all together in a future release. Note: Documentation should probably also be updated to remove mentioning this.
NickLaMuro
force-pushed
the
soft-delete-zone-authentications
branch
from
386138b to
de2d90e
Compare
|
Checked commit NickLaMuro@de2d90e with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
@kavyanekkalapu updated with screenshots |
thank you, will review today. |
kavyanekkalapu
approved these changes
Apr 22, 2021
|
LGTM, approved. |
Fryguy
approved these changes
Apr 29, 2021
NickLaMuro
added a commit
to NickLaMuro/manageiq-documentation
that referenced
this pull request
Apr 29, 2021
This is to be paired with ManageIQ/manageiq-ui-classic#7650 which will remove this feature from the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Auth on Zones from both the form view and the controller in the UI. Still allows them to be added via that
rails console, but removes the feature from the UI, with the intent to possibly remove from the product all together in a future release.Note: Documentation should probably also be updated to remove mentioning this.See Links below for docs PR.Also, this "addresses" ManageIQ/manageiq-api#898 by simply not making it a requirement to fix any more. Also should simplify #6917
Before
Admin
Links