-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted User Visual Settings form to be API-driven with DDF #7495
Conversation
f5091bd
to
12d341e
Compare
3864fd7
to
79fc0f5
Compare
Multiselect dropdowns with search capability are crashing, fix is here #7540 |
79fc0f5
to
8873bd0
Compare
app/javascript/components/visual-settings-form/visual-settings-form.schema.js
Show resolved
Hide resolved
Are there any unmerged dependencies? Trying to save the form, I get a 400: Invalid attribute(s) settings specified for a user ( |
(Also, all ddf selects now seem to only react to the second click. Once it's focused you can click to expand, but the first click only focuses, not expands. But that's also happening on master.) |
Seems like a bug in the API ManageIQ/manageiq-api#1001 |
Checked commit skateman@5e16d78 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint **
|
@himdel should be fine now, the dropdown issue is probably coming from DDF |
Agreed, the dropdown issue is not ours, so assuming that will likely be fixed by the carbon switch. Testing again :) |
Fixes #6934