Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted User Visual Settings form to be API-driven with DDF #7495

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 10, 2020

@miq-bot miq-bot added the wip label Nov 10, 2020
@skateman skateman force-pushed the ui-settings branch 2 times, most recently from f5091bd to 12d341e Compare November 30, 2020 13:29
@skateman skateman force-pushed the ui-settings branch 2 times, most recently from 3864fd7 to 79fc0f5 Compare December 11, 2020 11:39
@skateman
Copy link
Member Author

Multiselect dropdowns with search capability are crashing, fix is here #7540

@skateman skateman changed the title [WIP] Converted User Visual Settings form to be API-driven with DDF Converted User Visual Settings form to be API-driven with DDF Dec 11, 2020
@miq-bot miq-bot removed the wip label Dec 11, 2020
@skateman skateman changed the title Converted User Visual Settings form to be API-driven with DDF [WIP] Converted User Visual Settings form to be API-driven with DDF Jan 15, 2021
@miq-bot miq-bot added the wip label Jan 15, 2021
@h-kataria h-kataria assigned himdel and unassigned h-kataria Jan 18, 2021
@skateman skateman changed the title [WIP] Converted User Visual Settings form to be API-driven with DDF Converted User Visual Settings form to be API-driven with DDF Jan 19, 2021
@miq-bot miq-bot removed the wip label Jan 19, 2021
@himdel
Copy link
Contributor

himdel commented Feb 3, 2021

Are there any unmerged dependencies?

Trying to save the form, I get a 400: Invalid attribute(s) settings specified for a user

(PATCH http://localhost:3000/api/users/10000000000001
Returns {"error":{"kind":"bad_request","message":"Invalid attribute(s) settings specified for a user","klass":"Api::BadRequestError"}})

@himdel
Copy link
Contributor

himdel commented Feb 3, 2021

(Also, all ddf selects now seem to only react to the second click. Once it's focused you can click to expand, but the first click only focuses, not expands. But that's also happening on master.)

@skateman
Copy link
Member Author

skateman commented Feb 4, 2021

Are there any unmerged dependencies?

Trying to save the form, I get a 400: Invalid attribute(s) settings specified for a user

(PATCH http://localhost:3000/api/users/10000000000001
Returns {"error":{"kind":"bad_request","message":"Invalid attribute(s) settings specified for a user","klass":"Api::BadRequestError"}})

Seems like a bug in the API ManageIQ/manageiq-api#1001

@miq-bot
Copy link
Member

miq-bot commented Feb 4, 2021

Checked commit skateman@5e16d78 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
5 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@skateman
Copy link
Member Author

skateman commented Feb 4, 2021

@himdel should be fine now, the dropdown issue is probably coming from DDF

@himdel
Copy link
Contributor

himdel commented Feb 4, 2021

Agreed, the dropdown issue is not ours, so assuming that will likely be fixed by the carbon switch.

Testing again :)

@himdel himdel merged commit 2457526 into ManageIQ:master Feb 5, 2021
@skateman skateman deleted the ui-settings branch February 5, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form conversion: My Settings Visual
5 participants