Policy profile de-explorization #7348

h-kataria · 2020-09-28T17:55:36Z

RBAC Product feature changes in ManageIQ/manageiq#20820
Data migration ManageIQ/manageiq-schema#541

before

after
2

@skateman ready for review

skateman

I guess it would help you if the form would be in DDF, I will see what I can do 😉

skateman · 2020-12-15T11:02:27Z

app/helpers/application_helper/toolbar_chooser.rb

@@ -469,7 +467,7 @@ def center_toolbar_filename_classic
            container_build
            infra_networking
            infra_topology
-            ems_storage
+            ems_storagem


skateman · 2020-12-15T11:03:20Z

app/presenters/menu/default_menu.rb

@@ -222,7 +222,7 @@ def object_storage_menu_section

      def control_menu_section
        Menu::Section.new(:con, N_("Control"), 'carbon--IbmSecurity', [
-          Menu::Item.new('miq_policy_set',    N_('Policy Profiles'), 'miq_policy_set',       {:feature => 'miq_policy_set', :any => true}, '/miq_policy_set/explorer'),
+          Menu::Item.new('miq_policy_set',    N_('Policy Profiles'), 'miq_policy_set',       {:feature => 'miq_policy_set/show_list'}, '/miq_policy_set/show_list'),


There's no such feature, you can keep the original one here + the updated link

- And fixed failing spec tests

Also updated startpage shortcut url for ManageIQ/manageiq-ui-classic#7348

for ManageIQ/manageiq-ui-classic#7348

- Removed leftover tree related file.

skateman · 2021-01-04T11:37:18Z

app/views/miq_policy_set/_profile_details.html.haml

+          %tr{:class => "no-hover"}
+            -# uncomment following 2 lines when de-explorizing
+            -#%tr{:title => _("View this %{model} Policy") % {:model => ui_lookup(:model => p.towhat)},
+            -#:onclick => remote_function(:url => "/miq_policy/show/xx-#{p.mode}_xx-#{p.mode}-#{p.towhat}_p-#{p.id}")}


Umm, aren't you de-explorerizing here?

@skateman yes, but Polcy explorer is not de-explorized yet, so i am going to add all the links back in all these non-explorized versions once they are merged in one single PR.

- Removed redundant `button` route

miq-bot · 2021-01-04T23:20:50Z

Checked commits h-kataria/manageiq-ui-classic@8a22bb0~...84bdefd with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
23 files checked, 2 offenses detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

💣 💥 🔥 🚒 - Linter/Rubocop - Linter::Rubocop STDERR:

app/presenters/menu/default_menu.rb: Metrics/LineLength has the wrong namespace - should be Layout
/tmp/d20210104-7-wca8fe/config/routes.rb: Warning: no department given for MultilineOperationIndentation. Run `rubocop -a --only Migration/DepartmentName` to fix.

skateman

Also updated startpage shortcut url for ManageIQ/manageiq-ui-classic#7348

- Also updated startpage shortcut url - Added missing dictionary entry for `miq_action` for ManageIQ/manageiq-ui-classic#7348

for ManageIQ/manageiq-ui-classic#7348

h-kataria added enhancement wip labels Sep 28, 2020

h-kataria requested a review from skateman September 28, 2020 17:55

h-kataria assigned skateman Sep 28, 2020

h-kataria mentioned this pull request Sep 28, 2020

Convert explorers to non-explorer style screens #6819

Open

42 tasks

miq-bot added the unmergeable label Nov 13, 2020

h-kataria force-pushed the policy_profile_dexplorization branch from d8efe2e to 7ae8367 Compare November 13, 2020 20:26

h-kataria removed unmergeable wip labels Nov 15, 2020

h-kataria changed the title ~~[WIP] - Policy profile de-explorization~~ Policy profile de-explorization Nov 15, 2020

h-kataria mentioned this pull request Nov 17, 2020

Added show_list/show features to support Policy Profile de-explorization changes ManageIQ/manageiq#20820

Merged

h-kataria force-pushed the policy_profile_dexplorization branch from 78917b6 to 9ac7f25 Compare November 17, 2020 17:56

skateman suggested changes Dec 15, 2020

View reviewed changes

h-kataria added 4 commits December 27, 2020 12:23

Policy Profile explorer de-explorized version

8a22bb0

Fixed some other minor issues with add/edit of records.

2a13ee4

- And fixed failing spec tests

Load toolbars from controller.

a9e2047

Removed references of Policy Profile tree

26bee65

h-kataria force-pushed the policy_profile_dexplorization branch from 9ac7f25 to 26bee65 Compare December 27, 2020 17:24

Fixed RBAC product feature check

a3f065f

h-kataria added a commit to h-kataria/manageiq that referenced this pull request Dec 30, 2020

Added show_list/show features to support de-explorization changes

fae7943

Also updated startpage shortcut url for ManageIQ/manageiq-ui-classic#7348

h-kataria added a commit to h-kataria/manageiq-schema that referenced this pull request Dec 30, 2020

Start page url data migration for Actions De-explorization

21feb1a

for ManageIQ/manageiq-ui-classic#7348

fixed an accidentally committed typo and removed debug statement

1e55563

- Removed leftover tree related file.

h-kataria force-pushed the policy_profile_dexplorization branch from 40bd977 to 1e55563 Compare December 30, 2020 22:04

h-kataria added 3 commits January 1, 2021 21:51

Fixed routing spec test

02874cf

Missed adding show_list and deleting profile_list in previous commit

fe329b1

split profile details and form into their own views

6d133ae

skateman reviewed Jan 4, 2021

View reviewed changes

h-kataria mentioned this pull request Jan 4, 2021

Data Migration for Policy Profile Startpage url update ManageIQ/manageiq-schema#541

Merged

Removed redundant include of GenericButtonMixin

84bdefd

- Removed redundant `button` route

h-kataria force-pushed the policy_profile_dexplorization branch from aabc4f1 to 84bdefd Compare January 4, 2021 23:17

skateman approved these changes Jan 5, 2021

View reviewed changes

gtanzillo merged commit 7fefaed into ManageIQ:master Jan 5, 2021

This was referenced Jan 11, 2021

Added show_list/show features to support MiqAction de-explorization changes ManageIQ/manageiq#20944

Merged

Start page url data migration for Actions De-explorization ManageIQ/manageiq-schema#547

Merged

h-kataria deleted the policy_profile_dexplorization branch January 18, 2021 21:50

himdel mentioned this pull request Jan 28, 2021

Dead render partial #7609

Merged

h-kataria added a commit to h-kataria/manageiq that referenced this pull request Feb 8, 2021

Added show_list/show features to support de-explorization changes

ea9bbaa

Also updated startpage shortcut url for ManageIQ/manageiq-ui-classic#7348

h-kataria added a commit to h-kataria/manageiq that referenced this pull request Feb 10, 2021

Added show_list/show features to support de-explorization changes

d56f7b5

Also updated startpage shortcut url for ManageIQ/manageiq-ui-classic#7348

h-kataria added a commit to h-kataria/manageiq that referenced this pull request Feb 10, 2021

Added show_list/show features to support de-explorization changes

fac0180

- Also updated startpage shortcut url - Added missing dictionary entry for `miq_action` for ManageIQ/manageiq-ui-classic#7348

h-kataria added a commit to h-kataria/manageiq-schema that referenced this pull request Feb 10, 2021

Start page url data migration for Actions De-explorization

879902f

for ManageIQ/manageiq-ui-classic#7348

h-kataria added a commit to h-kataria/manageiq-schema that referenced this pull request Feb 12, 2021

Start page url data migration for Actions De-explorization

6085160

for ManageIQ/manageiq-ui-classic#7348

chessbyte mentioned this pull request Feb 23, 2021

[Lasker] Convert explorers to non-explorer style screens #7641

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Policy profile de-explorization #7348

Policy profile de-explorization #7348

h-kataria commented Sep 28, 2020 •

edited

Loading

skateman left a comment

skateman Dec 15, 2020

skateman Dec 15, 2020

skateman Jan 4, 2021

h-kataria Jan 4, 2021

skateman Jan 4, 2021

miq-bot commented Jan 4, 2021

skateman left a comment

Policy profile de-explorization #7348

Policy profile de-explorization #7348

Conversation

h-kataria commented Sep 28, 2020 • edited Loading

skateman left a comment

Choose a reason for hiding this comment

skateman Dec 15, 2020

Choose a reason for hiding this comment

skateman Dec 15, 2020

Choose a reason for hiding this comment

skateman Jan 4, 2021

Choose a reason for hiding this comment

h-kataria Jan 4, 2021

Choose a reason for hiding this comment

skateman Jan 4, 2021

Choose a reason for hiding this comment

miq-bot commented Jan 4, 2021

skateman left a comment

Choose a reason for hiding this comment

h-kataria commented Sep 28, 2020 •

edited

Loading