Convert my settings tabs to react

ManageIQ · Nov 21, 2023 · 3dc47fd · 3dc47fd
1 parent fc17035
commit 3dc47fd
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 31 deletions.
diff --git a/app/controllers/configuration_controller.rb b/app/controllers/configuration_controller.rb
@@ -20,7 +20,7 @@ def title
   end
 
   def index
-    show_timeprofiles
+    # show_timeprofiles
     assert_privileges('my_settings_view')
     @breadcrumbs = []
     active_tab = nil
@@ -72,8 +72,6 @@ def edit
 
   # New tab was pressed
   def change_tab
-    # require 'byebug'
-    # byebug
     assert_privileges('my_settings_admin')
     set_tab_vars(params['uib-tab'])
     @tabform = "ui_" + params['uib-tab'] if params['uib-tab'] != "5"

diff --git a/app/helpers/configuration_helper.rb b/app/helpers/configuration_helper.rb
diff --git a/app/javascript/components/miq-custom-tab/index.jsx b/app/javascript/components/miq-custom-tab/index.jsx
@@ -9,7 +9,6 @@ const MiqCustomTab = ({ containerId, tabLabels, type }) => {
     { type: 'CATALOG_EDIT' },
     { type: 'CATALOG_REQUEST_INFO', url: `/miq_request/prov_field_changed?tab_id=${name}&edit_mode=true` },
     { type: 'UTILIZATION' },
-    { type: 'SETTINGS' },
   ];
 
   const configuration = (name) => tabConfigurations(name).find((item) => item.type === type);

diff --git a/app/views/layouts/_tabs.html.haml b/app/views/layouts/_tabs.html.haml
@@ -1,7 +1,6 @@
 - if @tabs
   #custom-tabs-wrapper.miq_custom_tab_wrapper
     - if @path.present?
-      = @current_tab
       = react('CustomURLTabs', {:tabs => @tabs, :path => @path, :currentTab => @current_tab, :checkForChanges => @check_for_changes})
     - else
       %ul{'role' => 'tablist', :class => "nav nav-tabs #{@layout == 'dashboard' ? 'nav-tabs-pf' : nil}"}