Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop pylxca python2 dependency #287

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Drop pylxca python2 dependency #287

merged 2 commits into from
Jul 6, 2022

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 6, 2022 •
edited
Loading

  • Fix path for .egg-info directory
  • Drop test directory since it shouldn't be needed in production. A test file had a shebang referring to python 2.7 which caused dnf to also require /usr/bin/python2.7. We shouldn't need any python2 files as this is all using python3.

bdunne added 2 commits July 6, 2022 17:16
@bdunne
Fix path for .egg-info directory
d104e04
@bdunne
Drop test directory since it shouldn't be needed in production
91d4cd1 
A test file had a shebang referring to python 2.7 which caused dnf to also
require /usr/bin/python2.7.  We shouldn't need any python2 files as this is
all using python3.
@miq-bot
Copy link
Member

miq-bot commented Jul 6, 2022

Checked commits bdunne/manageiq-rpm_build@d104e04~...91d4cd1 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 0266fa0 into ManageIQ:master Jul 6, 2022
@bdunne bdunne deleted the drop_pylxca_python2_dependency branch July 7, 2022 01:05
@Fryguy Fryguy mentioned this pull request Jul 21, 2022
Open
@Fryguy
Copy link
Member

Fryguy commented Aug 10, 2022

Backported to najdorf in commit f6348d1.

commit f6348d1c3df0a749205a1c6725e7e056142c477b
Author: Jason Frey <[email protected]>
Date:   Wed Jul 6 19:20:02 2022 -0400

    Merge pull request #287 from bdunne/drop_pylxca_python2_dependency
    
    Drop pylxca python2 dependency
    
    (cherry picked from commit 0266fa06ae111310e299eb6412b0a8788d325126)

Fryguy added a commit that referenced this pull request Aug 10, 2022
@Fryguy
Merge pull request #287 from bdunne/drop_pylxca_python2_dependency
f6348d1 
Drop pylxca python2 dependency

(cherry picked from commit 0266fa0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
dependencies najdorf/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdunne @miq-bot @Fryguy