Fix vCloud and Tanzu inheriting vSphere's filtered events #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BaseManager.default_blacklisted_event_names method uses the provider name (aka Vmware) rather than the ems_type so all ManageIQ::Providers::Vmware::*Managers were getting the vSphere blacklisted events
|
@miq-bot cross-repo-tests ManageIQ/manageiq@master |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jan 28, 2025
From Pull Request: ManageIQ/manageiq-providers-vmware#936
Fryguy
approved these changes
Jan 28, 2025
agrare
commented
Jan 28, 2025
| @@ -337,6 +337,10 @@ def self.provision_class(via) | |||
| end | |||
| end | |||
|
|
|||
| def self.default_blacklisted_event_names | |||
| Settings.ems.ems_vmware.blacklisted_event_names | |||
There was a problem hiding this comment.
NOTE this one can't use ems_type because for the infra_manager ems_type is vmwarews not vmware
agrare
deleted the
fix_vmware_default_blacklisted_event_names_other_providers
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseManager.default_blacklisted_event_namesmethod uses the provider name (aka Vmware) rather than theems_typeso allManageIQ::Providers::Vmware::*Managerswere getting the vSphere blacklisted events