Added supported_catalog_types #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
reviewed
Dec 8, 2017
| @@ -41,6 +41,10 @@ def supports_authentication?(authtype) | |||
| supported_auth_types.include?(authtype.to_s) | |||
| end | |||
|
|
|||
| def supported_catalog_types | |||
| %w(vmware) | |||
There was a problem hiding this comment.
Are any orchestration templates supported by vSphere?
There was a problem hiding this comment.
@agrare
Orchestration templates are not supported for vSphere.
There was a problem hiding this comment.
So should this be left as [] ? or rather not overridden at all
There was a problem hiding this comment.
@agrare This is not for orchestration templates alone, this is for service that provision a vm.
There was a problem hiding this comment.
Ah okay didn't realize that thanks
|
Checked commit mkanoor@5ed5138 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Dec 11, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
Added supported_catalog_types (cherry picked from commit 5b35b19) https://bugzilla.redhat.com/show_bug.cgi?id=1520613
|
Gaprindashvili backport details: |
agrare
pushed a commit
to agrare/manageiq-providers-vmware
that referenced
this pull request
Apr 15, 2019
…interval Changed ae_retry_limit = 1.minute to ae_retry_interval = 1.minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For service catalog each provider needs to report the supported catalog types.
Needed for PR ManageIQ/manageiq#16559