This repository was archived by the owner on Jul 25, 2023. It is now read-only.
Fix exception handing for credential validation on raw_connect #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jntullo |
This was referenced Nov 7, 2017
Fix exception handing for credential validation on raw_connect
ManageIQ/manageiq-providers-google#28
Merged
tumido
force-pushed
the
fix_cred_validation
branch
from
9e0000a to
a02871b
Compare
|
Checked commit tumido@a02871b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
agrare
approved these changes
Nov 7, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
Fix exception handing for credential validation on raw_connect (cherry picked from commit 1d92cea)
|
Gaprindashvili backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When provider is added the credentials validation is newly done via
raw_connect(class method) instead ofverify_credentials(needed EMS object). Further reading on this change can be found here: ManageIQ/manageiq-ui-classic#1580This change ensures that exceptions are handled properly, because the
verify_credentialsis not called anymore.Related issues on other providers: