Test az_to_cn method from super #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
force-pushed
the
add_tests_for_allowed_cloud_networks
branch
from
254719b to
4583169
Compare
|
Checked commit d-m-u@4583169 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
test failure is unrelated, merging. |
|
thanks @mansam!! |
simaishi
pushed a commit
that referenced
this pull request
Mar 20, 2018
Test az_to_cn method from super (cherry picked from commit 591e223)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ManageIQ/manageiq#16811 adds RBAC filtering to allowed_cloud_network base class and openstack needed specs around the fact that the cloud network list is NOT dependent on availability zone choice unlike azure and amazon. (Per ManageIQ/manageiq#16824 (comment))
Related bz links:
https://bugzilla.redhat.com/show_bug.cgi?id=1533277
https://bugzilla.redhat.com/show_bug.cgi?id=1535189