Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supported_catalog_types #74

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Dec 8, 2017

For Service Catalogs each provider manager needs to provide the catalog types it supports

Needed for ManageIQ/manageiq#16559

@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2017

Checked commit mkanoor@4acd9f5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@mkanoor
Copy link
Contributor Author

mkanoor commented Dec 8, 2017

@Fryguy @agrare
Please review

@agrare agrare self-assigned this Dec 11, 2017
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agrare agrare merged commit 89a8936 into ManageIQ:master Dec 11, 2017
@agrare agrare added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 11, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
@simaishi
Copy link

Gaprindashvili backport details:

$ git log -1
commit 48fd8e39cc75ad6ef8b1dffeaab540dbdc609e36
Author: Adam Grare <[email protected]>
Date:   Mon Dec 11 13:02:08 2017 -0500

    Merge pull request #74 from mkanoor/supported_catalog_types
    
    Added supported_catalog_types
    (cherry picked from commit 89a89365c7d6b9425b830dbfd174bc8d40ea2216)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants