Handle subnets with missing gateway/netmask #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We crash hard in case gateway address returned from Nuage API is `nil`. Well, not anymore. Signed-off-by: Miha Pleško <[email protected]>
|
LGTM 👍 |
|
Now that is a response time I could get used to 👍 😄 |
You caught me at a good time! I should have left it three days to keep up the illusion :) |
simaishi
pushed a commit
that referenced
this pull request
Apr 3, 2018
Handle subnets with missing gateway/netmask (cherry picked from commit b47c8d0) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1563351
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We crash hard in case gateway address returned from Nuage API is
nil. Well, not anymore.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1551015
@miq-bot add_label bug,gaprindashvili/yes
@miq-bot assign @juliancheal