Enable Nuage network manager #33
Conversation
Prior to this patch, the UI could not show the option to create new network managers because these are typically created along with cloud manager. Nuage is a dedicated SDN requiring ability to add the provider manually. The UI depends on the `product.nuage` setting to enable the network providers which this patch adds directly into the Nuage. Signed-off-by: Gregor Berginc <[email protected]>
gberginc
force-pushed
the
enable_nuage_product
branch
from
e57147f to
24ddb09
Compare
|
Checked commit gberginc@24ddb09 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@blomquisg @gberginc IMO this PR should be reverted because it's causing an issue where it will always enable the UI edit/new menu. Instead we should rely on the |
|
If I recal correctly, this is indeed not enabled in downstream product, so this should not be a probem to revert. I fully support the decision not to have Nuage-specific check in the UI. @miha-plesko what do you think? |
|
Will test tomorrow but I think the PR will prevent user from adding the first Nuage manager. I'm thinking if we should instead check for |
|
@miha-plesko Pretty sure you're correct. I'm not familiar with config/permissions.yaml, but it sounds promising. |
|
So there is another PR available to fix the issue: ManageIQ/manageiq-ui-classic#3979, I suggest we continue our discussion there. |
Prior to this patch, the UI could not show the option to create new
network managers because these are typically created along with cloud
manager. Nuage is a dedicated SDN requiring ability to add the provider
manually.
The UI depends on the
product.nuagesetting to enable the networkproviders which this patch adds directly into the Nuage.
@miq-bot assign @blomquisg
@miq-bot add_label enhancement