Use AMQP fallback endpoints when available #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip Marking wip because we are working with the UI PR in parallel |
miq-bot
changed the title
Qpid proton allows for automatic failover in case an error occurs for the currently active connection. When the Nuage provider is associated with endpoints with roles `amqp-fallback1` and `amqp-fallback2`, these will be used to configure the message handler. Signed-off-by: Gregor Berginc <[email protected]>
gberginc
force-pushed
the
use_amqp_fallbacks
branch
from
ed071c7 to
3833be8
Compare
|
Checked commit gberginc@3833be8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot remove_label wip @miq-bot assign @blomquisg This PR adds the support for multiple URLs. The PR description has a video that demonstrates the behaviour. |
miq-bot
changed the title
|
LGTM 👍 Love the video! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qpid proton allows for automatic failover in case an error occurs for
the currently active connection. When the Nuage provider is associated
with endpoints with roles
amqp-fallback1andamqp-fallback2, thesewill be used to configure the message handler.
Video showing the behaviour of the fallback: https://youtu.be/w-AekPyMOmo.
@miq-bot add_label events