-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign Nuage event types to timeline categories #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tadeboro for the actual mapping. So the example that I pointed you to is not the most recent hence we need to adjust it a little bit to match what we actually need for Nuage. Sorry about that.
config/settings.yml
Outdated
:update: | ||
:critical_regex: | ||
- ^nuage_.+_update$ | ||
:detail: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just remove :detail:
category. We want all events to land in :critical:
at this point and will decide which ones to degradate to :detail:
later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I simply converted the code from the older pull request.
config/settings.yml
Outdated
- nuage_vsc_update | ||
- nuage_vrs_update | ||
:status: # alarms | ||
:critical: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed a little, please remove the :critical:
category and simply use
:critical_regex:
- ^nuage_alarm_.*$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider it done.
3e6aca9
to
7bc30f2
Compare
The required work has been merged into core and ui, so this can now be tested against latest master branches of those repositories. @miq-bot remove_label wip |
This will make Nuage events visible in "Monitoring -> Timelines" view. At the moment, all of the events are assigned critical category, but this can be easily changed later.
Checked commit xlab-si@d84b3b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Kicking Travis now that log directory PR is merged |
Tested and it works like a charm, thanks @tadeboro! |
@miha-plesko - Can you add a screenshot? |
@bronaghs I put some Nuage provider screenshots to this issue here, Event Timelines are also there: https://github.com/ManageIQ/manageiq-providers-nuage/issues/140#issuecomment-416866018 Please let me know if you need some more. |
This will make Nuage events visible in "Monitoring -> Timelines" view.
This pull request depends on ManageIQ/manageiq-ui-classic#4375 and is replacing #80.
@miq-bot add_label wip
/cc @miha-plesko @gberginc