Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Nuage event types to timeline categories #119

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

tadeboro
Copy link
Contributor

This will make Nuage events visible in "Monitoring -> Timelines" view.

This pull request depends on ManageIQ/manageiq-ui-classic#4375 and is replacing #80.

@miq-bot add_label wip

/cc @miha-plesko @gberginc

@miq-bot miq-bot changed the title Assign Nuage event types to timeline categories [WIP] Assign Nuage event types to timeline categories Jul 29, 2018
@miq-bot miq-bot added the wip label Jul 29, 2018
@miha-plesko
Copy link
Contributor

Copy link
Contributor

@miha-plesko miha-plesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tadeboro for the actual mapping. So the example that I pointed you to is not the most recent hence we need to adjust it a little bit to match what we actually need for Nuage. Sorry about that.

:update:
:critical_regex:
- ^nuage_.+_update$
:detail:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove :detail: category. We want all events to land in :critical: at this point and will decide which ones to degradate to :detail: later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. I simply converted the code from the older pull request.

- nuage_vsc_update
- nuage_vrs_update
:status: # alarms
:critical:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has changed a little, please remove the :critical: category and simply use

:critical_regex:
- ^nuage_alarm_.*$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider it done.

@tadeboro tadeboro force-pushed the timelines branch 2 times, most recently from 3e6aca9 to 7bc30f2 Compare August 20, 2018 04:40
@tadeboro
Copy link
Contributor Author

The required work has been merged into core and ui, so this can now be tested against latest master branches of those repositories.

@miq-bot remove_label wip
@miq-bot assign @miha-plesko

@miq-bot miq-bot changed the title [WIP] Assign Nuage event types to timeline categories Assign Nuage event types to timeline categories Aug 20, 2018
@miq-bot miq-bot removed the wip label Aug 20, 2018
This will make Nuage events visible in "Monitoring -> Timelines" view.

At the moment, all of the events are assigned critical category, but
this can be easily changed later.
@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2018

Checked commit xlab-si@d84b3b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@miha-plesko miha-plesko reopened this Aug 21, 2018
@miha-plesko
Copy link
Contributor

Kicking Travis now that log directory PR is merged

@miha-plesko
Copy link
Contributor

Tested and it works like a charm, thanks @tadeboro!

@miha-plesko miha-plesko merged commit d874e02 into ManageIQ:master Aug 21, 2018
@tadeboro tadeboro deleted the timelines branch August 21, 2018 08:21
@miha-plesko miha-plesko added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 21, 2018
@bronaghs
Copy link

@miha-plesko - Can you add a screenshot?

@miha-plesko
Copy link
Contributor

@bronaghs I put some Nuage provider screenshots to this issue here, Event Timelines are also there: https://github.com/ManageIQ/manageiq-providers-nuage/issues/140#issuecomment-416866018

Please let me know if you need some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants