Temporarily remove many-to-many from NetworkRouter #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
reviewed
Jul 13, 2018
| @@ -1,3 +1,4 @@ | |||
| class ManageIQ::Providers::Nuage::NetworkManager::NetworkRouter < ::NetworkRouter | |||
| has_many :floating_ips, :dependent => :destroy | |||
| # TODO(miha-plesko): uncomment when https://github.com/ManageIQ/manageiq-schema/pull/217 is merged | |||
| # has_many :floating_ips, :dependent => :destroy | |||
There was a problem hiding this comment.
the best might be to define:
def floating_ips
FloatingIp.none
endso you can have it used in UI or other places, but it will just return blank result until properly implemented
There was a problem hiding this comment.
Makes sense, done.
With this commit we remove relation which allows NetworkRouter to relate to multiple FloatingIps directly (instead via CloudNetwork). Until ManageIQ/manageiq-schema#217 is merged we are not able to use such direct relation or else UI crashes. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
comment-out-router-key
branch
from
031e3dc to
4d2221a
Compare
Ladas
approved these changes
Jul 13, 2018
|
Checked commit miha-plesko@4d2221a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we remove relation which allows NetworkRouter to relate to multiple FloatingIps directly (instead via CloudNetwork). Until ManageIQ/manageiq-schema#217 is merged we are not able to use such direct relation or else UI crashes.