Inventory vPort entities (Nuage) into NetworkPort model (MIQ) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miha-plesko
force-pushed
the
inventory-vports
branch
from
ae4bc1a to
b097af3
Compare
Ladas
reviewed
Jul 12, 2018
|
|
||
| def add_cloud_subnet_network_ports(extra_properties = {}) | ||
| add_collection(network, :cloud_subnet_network_ports, extra_properties) do |builder| | ||
| builder.add_properties(:parent => manager, :parent_inventory_collections => %i(network_ports)) |
There was a problem hiding this comment.
could you fix this 1 rubocop nit? There is extra space
With this commit we inventory NetworkPorts that can be of different types in Nuage: - Bridge vPort - Host vPort - VM vPort - Container vPort Each of them has a unique way of retrieving IP address by performing additional API request, hence the case-when statement in the parser. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574927 Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
inventory-vports
branch
from
b097af3 to
a0d7b24
Compare
|
Yeah, had to run somewhere yesterday then I didn't come back until today. Sorry it took me a day to remove this single space. |
|
Checked commit miha-plesko@a0d7b24 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we inventory NetworkPorts that can be of different
types in Nuage:
Each of them has a unique way of retrieving IP address by performing additional API request, hence the case-when statement in the parser.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574927