Merge pull request #43 from gasper-vrhovsek/feature/security_protocol…

…_pretty_error Human readable error when selecting wrong security protocol (cherry picked from commit 8ac64a6)
ManageIQ · Dec 19, 2017 · 110b7a7 · 110b7a7
1 parent 935da22
commit 110b7a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/app/models/manageiq/providers/nuage/manager_mixin.rb b/app/models/manageiq/providers/nuage/manager_mixin.rb
@@ -35,6 +35,8 @@ def translate_exception(err)
         MiqException::MiqHostError.new("Socket error: #{err.message}")
       when MiqException::MiqInvalidCredentialsError, MiqException::MiqHostError
         err
+      when Net::HTTPBadResponse
+        MiqException::MiqEVMLoginError.new("Login failed due to a bad security protocol, hostname or port.")
       else
         MiqException::MiqEVMLoginError.new("Unexpected response returned from system: #{err.message}")
       end

diff --git a/spec/models/manageiq/providers/nuage/network_manager_spec.rb b/spec/models/manageiq/providers/nuage/network_manager_spec.rb
@@ -119,6 +119,12 @@
       allow(@ems).to receive(:with_provider_connection).and_raise(exception)
       expect { @ems.verify_credentials }.to raise_error(MiqException::MiqHostError, /invalid host/)
     end
+
+    it 'handles Net::HTTPBadResponse' do
+      exception = Net::HTTPBadResponse.new
+      allow(@ems).to receive(:with_provider_connection).and_raise(exception)
+      expect { @ems.verify_credentials }.to raise_error(MiqException::MiqEVMLoginError, /Login failed due to a bad security protocol, hostname or port./)
+    end
   end
 
   context '#authentications_to_validate' do