Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added South America region #48

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Added South America region #48

merged 1 commit into from
Feb 26, 2018

Conversation

juliancheal
Copy link
Member

@juliancheal
Copy link
Member Author

Will create follow up PR to allow adding additional regions same as amazon https://github.com/ManageIQ/manageiq-providers-amazon/blob/365c64262effff2e43790aea85fa323bab1303a8/config/settings.yml#L30-L39

@juliancheal
Copy link
Member Author

screen shot 2018-02-26 at 15 58 45

@miq-bot miq-bot added the wip label Feb 26, 2018
@juliancheal juliancheal changed the title [WIP] Added South America region Added South America region Feb 26, 2018
@miq-bot miq-bot removed the wip label Feb 26, 2018
@juliancheal
Copy link
Member Author

juliancheal commented Feb 26, 2018 •
edited
Loading

What am I missing, #48 (comment) the hashes looked aligned to me?

@agrare
Copy link
Member

agrare commented Feb 26, 2018

@juliancheal probably two things,

  1. there are more spaces than needed in that region hash
  2. the region name is longer so you need to align the other region name hashes, https://github.com/juliancheal/manageiq-providers-google/blob/cdb07f6df0f4d8f724d3ca36bb624e0621254948/app/models/manageiq/providers/google/regions.rb#L26

@juliancheal
Copy link
Member Author

@miq-bot add_label gaprindashvili/yes

@juliancheal
Copy link
Member Author

@miq-bot assign @agrare

agrare
agrare approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2018

Checked commit 5764051 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit 2c1faeb into ManageIQ:master Feb 26, 2018
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 26, 2018
@simaishi
Copy link
Contributor

@juliancheal Can this be fine/yes ?

@juliancheal
Copy link
Member Author

@simaishi Yeah fine/yes

@juliancheal
Copy link
Member Author

@miq-bot add_label fine/yes

@simaishi
Copy link
Contributor

simaishi commented Mar 5, 2018

Fine backport (to manageiq repo) details:

$ git log -1
commit 685ffac1c583510a3afb5332bc39f32a6b481ca1
Author: Adam Grare <[email protected]>
Date:   Mon Feb 26 12:02:28 2018 -0500

    Merge pull request #48 from juliancheal/add_southamerica_region
    
    Added South America region
    (cherry picked from commit 2c1faebf533feea0792e77a69c5f8c389439a271)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551699

simaishi pushed a commit that referenced this pull request Mar 6, 2018
@agrare @simaishi
Merge pull request #48 from juliancheal/add_southamerica_region
939a713 
Added South America region
(cherry picked from commit 2c1faeb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551698
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 939a71316f63d11f5fc2c16721416f988eed2731
Author: Adam Grare <[email protected]>
Date:   Mon Feb 26 12:02:28 2018 -0500

    Merge pull request #48 from juliancheal/add_southamerica_region
    
    Added South America region
    (cherry picked from commit 2c1faebf533feea0792e77a69c5f8c389439a271)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliancheal @agrare @miq-bot @simaishi