Override az_zone_to_cloud_network method in google prov #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@miq-bot assign @gmcculloug |
This was referenced Jan 18, 2018
|
@syncrou @gmcculloug can you two please give this (hopefully) a final look? |
|
Checked commit d-m-u@487da15 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
|
@miq_bot add_label blocker |
gmcculloug
approved these changes
Jan 18, 2018
|
@d-m-u Since this depends on ManageIQ/manageiq#16824, which is not merged, I will hold off merging this. Adding the WIP label. |
|
@bronaghs |
bronaghs
approved these changes
Jan 19, 2018
|
@d-m-u - Blocker label? |
|
@bronaghs yes please! I tried to add yesterday but bot ignored me :( |
|
cheeky bot! |
simaishi
pushed a commit
that referenced
this pull request
Jan 19, 2018
…_google Override az_zone_to_cloud_network method in google prov (cherry picked from commit 1f6dd8b) https://bugzilla.redhat.com/show_bug.cgi?id=1536509
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment we need to override this method in google and openstack because the availability zone to subnet relationship isn't set up yet.
Fixes issue caused by fix of https://bugzilla.redhat.com/show_bug.cgi?id=1533277
(Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1535189)
Depends on:
ManageIQ/manageiq#16824
Related to:
ManageIQ/manageiq-providers-openstack#202