Skip to content

Commit

Permalink
Merge branch 'security-issue-65207-host-header-injection' into '5.12.z'
Browse files Browse the repository at this point in the history
Security issue 65207 Host Header Injection

See merge request cloudforms/cfme-appliance!13

(cherry picked from commit 181f07b)
  • Loading branch information
Fryguy committed Aug 7, 2020
1 parent ce70659 commit cf4f17c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions COPY/etc/httpd/conf.d/manageiq-host-config
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Default config (insecure)
ProxyPreserveHost on

# To make the appliance more secure and prevent Host Header Injection attacks,
# uncomment the following and change APPLIANCE_HOSTNAME to use the hostname
# address that the appliance is running on.
#
# RequestHeader set Host APPLIANCE_HOSTNAME
# RequestHeader set X-Forwarded-Host APPLIANCE_HOSTNAME
2 changes: 1 addition & 1 deletion COPY/etc/httpd/conf.d/manageiq-http.conf
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ RewriteRule ^.*$ https://%{SERVER_NAME}%{REQUEST_URI} [L,R]
# Include conf.d/manageiq-redirects-api
# Include conf.d/manageiq-redirects-ui
# Include conf.d/manageiq-redirects-websocket
# ProxyPreserveHost on
# Include conf.d/manageiq-host-config
# <Location /assets/>
# Header unset ETag
# FileETag None
Expand Down
2 changes: 1 addition & 1 deletion COPY/etc/httpd/conf.d/manageiq-https-application.conf
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Include conf.d/manageiq-redirects-cockpit
Include conf.d/manageiq-redirects-api
Include conf.d/manageiq-redirects-ui
Include conf.d/manageiq-redirects-websocket
ProxyPreserveHost on
Include conf.d/manageiq-host-config
RequestHeader set X_FORWARDED_PROTO 'https'

ErrorLog /var/www/miq/vmdb/log/apache/ssl_error.log
Expand Down

0 comments on commit cf4f17c

Please sign in to comment.