-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint for cloud subnets #1019
Conversation
Checked commit lfu@0e8c648 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint app/controllers/api/cloud_subnets_controller.rb
|
|
ping @abellotti @bdunne |
def create_resource(_type, _id = nil, data = {}) | ||
ems = ExtManagementSystem.find(data['ems_id']) | ||
klass = CloudSubnet.class_by_ems(ems) | ||
raise BadRequestError, "Create cloud subnet for Provider #{ems.name}: #{klass.unsupported_reason(:create)}" unless klass.supports?(:create) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be Cannot create cloud subnet ... same for the Update and Delete BadRequestError
Closing in favor of #1025 (which fixes the tests that are failing here) |
#1013
@miq-bot add_label enhancement, kasparov/no