[v2.x] Adds raw option for client get requests #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon3z
force-pushed
the
v2x-as-raw
branch
2 times, most recently
from
f3477a6 to
d032ca5
Compare
Prevents parsing of response body into Kubeclient objects (Recursive OpenStruct). In large kubernetes cluster environments, it could be implemented by saving off the raw json for later use, which can useful for memory tight scenarios.
simon3z
commented
Oct 10, 2017
lib/kubeclient/common.rb
Outdated
| define_singleton_method("get_#{entity.method_names[0]}") do |name, namespace = nil| | ||
| get_entity(klass, entity.resource_name, name, namespace) | ||
| define_singleton_method("get_#{entity.method_names[0]}") do |name, ns = nil, opts = {}| | ||
| get_entity(klass, entity.resource_name, name, ns, opts) |
There was a problem hiding this comment.
@NickLaMuro the namespace => ns renaming is backward-compatible?
There was a problem hiding this comment.
For consistency with the existing functions, this could be kept as namespace (instead of ns).
simon3z
force-pushed
the
v2x-as-raw
branch
3 times, most recently
from
30d73c2 to
dba0ff8
Compare
stefanmb
reviewed
Oct 10, 2017
lib/kubeclient/common.rb
Outdated
| define_singleton_method("get_#{entity.method_names[0]}") do |name, namespace = nil| | ||
| get_entity(klass, entity.resource_name, name, namespace) | ||
| define_singleton_method("get_#{entity.method_names[0]}") do |name, ns = nil, opts = {}| | ||
| get_entity(klass, entity.resource_name, name, ns, opts) |
There was a problem hiding this comment.
For consistency with the existing functions, this could be kept as namespace (instead of ns).
NickLaMuro
reviewed
Oct 10, 2017
test/test_kubeclient.rb
Outdated
| assert_equal(error_message, exception.message) | ||
| assert_equal(response, exception.response) | ||
|
|
||
| assert_requested(:get, 'http://localhost:8080/api/v1', times: 1) |
There was a problem hiding this comment.
This test needs to check against the new URL you changed it to in line 623 (will fix tests):
assert_requested(:get, 'http://username:password@localhost:8080/api/v1', times: 1)Signed-off-by: Federico Simoncelli <[email protected]>
simon3z
commented
Oct 11, 2017
| define_singleton_method("get_#{entity.method_names[0]}") do |name, namespace = nil| | ||
| get_entity(klass, entity.resource_name, name, namespace) | ||
| define_singleton_method("get_#{entity.method_names[0]}") \ | ||
| do |name, namespace = nil, opts = {}| |
There was a problem hiding this comment.
@NickLaMuro could you forward-port this so that master won't have to change to use ns instead of namespace?
simon3z
commented
Oct 11, 2017
test/test_kubeclient.rb
Outdated
| @@ -457,11 +457,11 @@ def test_get_all_raw | |||
| result = client.all_entities(as: :raw) | |||
| assert_equal(16, result.keys.size) | |||
|
|
|||
| %w[ | |||
| %w( | |||
There was a problem hiding this comment.
@NickLaMuro would we want to forward-port this as well?
|
Waiting for @cben and @moolitayer ACK on backward-compatibility. |
|
ack, LGTM. |
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 22, 2018
Reverts parts of commit 263ff40 from ManageIQ#271 that restored KubeException - no longer needed after backporting ManageIQ#195 and ManageIQ#233, we now have Kubeclient::HttpError and Kubeclient::ResourceNotFoundError. In other words, v2.x branch is now closer to original ManageIQ#262.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 22, 2018
Reverts parts of commit 263ff40 from ManageIQ#271 that restored KubeException - no longer needed after backporting ManageIQ#195 and ManageIQ#233, we now have Kubeclient::HttpError and Kubeclient::ResourceNotFoundError. In other words, v2.x branch is now closer to original ManageIQ#262.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 22, 2018
This reverts commit 263ff40 from ManageIQ#271. Those backport changes are no longer needed: - after backporting ManageIQ#195 and ManageIQ#233, v2.x now has Kubeclient::HttpError and Kubeclient::ResourceNotFoundError. - after backporting ManageIQ#247, v2.x now tests with webmock 2.x, it takes `basic_auth` rather than user:pw in URL. - ns/namespace change was just cosmetic. In other words, v2.x branch is now closer to original ManageIQ#262.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 25, 2018
This reverts commit 263ff40 from ManageIQ#271. Those backport changes are no longer needed: - after backporting ManageIQ#195 and ManageIQ#233, v2.x now has Kubeclient::HttpError and Kubeclient::ResourceNotFoundError. - after backporting ManageIQ#247, v2.x now tests with webmock 2.x, it takes `basic_auth` rather than user:pw in URL. - ns/namespace change was just cosmetic. In other words, v2.x branch is now closer to original ManageIQ#262.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NickLaMuro @stefanmb @cben @moolitayer can you review this backport of the raw option to the v2.x branch?
It seemed straight-forward to me and backward compatible (but please double-check that). Let's see if there are any travis failures.
Ref: #262
Thanks.