Require rest-client 2.x, drop 1.x support code #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15cd763.
|
+1 on the effort, haven't reviewed in detail. |
moolitayer
reviewed
Sep 24, 2017
| @@ -441,18 +441,6 @@ def api | |||
| JSON.parse(response) | |||
| end | |||
|
|
|||
| def self.restclient_read_timeout_option | |||
moolitayer
reviewed
Sep 24, 2017
kubeclient.gemspec
Outdated
| @@ -27,7 +27,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'webmock', '~> 3.0.1' | |||
| spec.add_development_dependency 'vcr' | |||
| spec.add_development_dependency 'rubocop', '= 0.49.1' | |||
| spec.add_dependency 'rest-client' | |||
| spec.add_dependency 'rest-client', '>= 2.0.0' | |||
There was a problem hiding this comment.
As discussed I'm fine with both ~> 2.0.0 or ~> 2.0 here.
There was a problem hiding this comment.
>= 2.0.0 was wrong as it would also accept 3.0.
Made it ~> 2.0 — will allow any 2.y.z; I don't want to pin to 2.0.z without specific reasons as rest-client is widely used gem...
Tests pass locally against:
- 2.0.0
- 2.0.2 (current)
- 2.1.0rc1
and rest-client is generally careful about backward compat so I think we can trust their semver.
I can make travis test against rest-client master in parallel to 2.0, if anyone wants.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 25, 2018
Backporting ManageIQ#223 bumped to rubocop with different defaults. These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269 but we didn't backport those.
cben
added a commit
to cben/kubeclient
that referenced
this pull request
Jan 25, 2018
Backporting ManageIQ#223 bumped to rubocop with different defaults. These rubocop errors are fixed on master by ManageIQ#253 and ManageIQ#269 but we didn't backport those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264.
Made it
~> 2.0— will allow any 2.y.z; I don't want to pin to 2.0.z without specific reasons as rest-client is widely used gem (and my impression is they're careful about compatibility so we can trust their semver)...Tests pass locally against: