-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relax requirement on recursive-open-struct #231
relax requirement on recursive-open-struct #231
Conversation
kubeclient requires recursive-open-struct to be 1.0.0. However, there has been, on recursive-open-struct, 2 minor updates (1.0.2) which fix 2 issues: https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md Let's make the requirement be ~>1.0.0 so that we can take the minor version fixes Fixes#230 Signed-off-by: Jordi Massaguer Pla <[email protected]>
@moolitayer @cben can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fyi in miq:
$ gem dependency recursive-open-struct --reverse-dependencies
Gem recursive-open-struct-1.0.0
bundler (>= 0, development)
pry (>= 0, development)
rake (>= 0, development)
rdoc (>= 0, development)
rspec (~> 3.2, development)
simplecov (>= 0, development)
Used by
image-inspector-client-1.0.3 (recursive-open-struct (= 1.0.0))
kubeclient-2.3.0 (recursive-open-struct (~> 1.0.0))
I will send the same update to image-inspector-client
fixes #231 |
Fixes #230 [PR can't fix itself :)] LGTM on BTW do we want to stop before 1.1.0 or before 2.0.0? If they follow semver, 1.y.z should all be backward-compatible, but with this rate of releases, just covering 1.0.z is fine and safer. |
😄
Unless there is a specific problem you think we should mitigate, using
👍 for not assuming minor version won't break us. |
…ent_on_recursive-open-struct relax requirement on recursive-open-struct
…ent_on_recursive-open-struct relax requirement on recursive-open-struct
…ent_on_recursive-open-struct relax requirement on recursive-open-struct (cherry picked from commit 7e957ac)
…ent_on_recursive-open-struct relax requirement on recursive-open-struct (cherry picked from commit 7e957ac)
kubeclient requires recursive-open-struct to be 1.0.0. However, there
has been, on recursive-open-struct, 2 minor updates (1.0.2) which fix 2
issues:
https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md
Let's make the requirement be ~>1.0.0 so that we can take the minor
version fixes
Fixes#230
Signed-off-by: Jordi Massaguer Pla [email protected]