Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax requirement on recursive-open-struct #231

Conversation

jordimassaguerpla
Copy link
Contributor

kubeclient requires recursive-open-struct to be 1.0.0. However, there
has been, on recursive-open-struct, 2 minor updates (1.0.2) which fix 2
issues:

https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md

Let's make the requirement be ~>1.0.0 so that we can take the minor
version fixes

Fixes#230

Signed-off-by: Jordi Massaguer Pla [email protected]

kubeclient requires recursive-open-struct to be 1.0.0. However, there
has been, on recursive-open-struct, 2 minor updates (1.0.2) which fix 2
issues:

https://github.com/aetherknight/recursive-open-struct/blob/master/CHANGELOG.md

Let's make the requirement be ~>1.0.0 so that we can take the minor
version fixes

Fixes#230

Signed-off-by: Jordi Massaguer Pla <[email protected]>
@simon3z
Copy link
Collaborator

simon3z commented Mar 3, 2017

@moolitayer @cben can you review?

Copy link
Collaborator

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fyi in miq:

$ gem dependency recursive-open-struct --reverse-dependencies
Gem recursive-open-struct-1.0.0
  bundler (>= 0, development)
  pry (>= 0, development)
  rake (>= 0, development)
  rdoc (>= 0, development)
  rspec (~> 3.2, development)
  simplecov (>= 0, development)
  Used by
    image-inspector-client-1.0.3 (recursive-open-struct (= 1.0.0))
    kubeclient-2.3.0 (recursive-open-struct (~> 1.0.0))

I will send the same update to image-inspector-client

@moolitayer
Copy link
Collaborator

fixes #231
(space missing above)

@cben
Copy link
Collaborator

cben commented Mar 5, 2017

Fixes #230 [PR can't fix itself :)]

LGTM on ~> not hardcoding minor version.
If the fixes in 1.0.2 are desirable, why not require at least 1.0.2?

BTW do we want to stop before 1.1.0 or before 2.0.0? If they follow semver, 1.y.z should all be backward-compatible, but with this rate of releases, just covering 1.0.z is fine and safer.
According to https://robots.thoughtbot.com/rubys-pessimistic-operator, if we want >= 1.0.2 and < 1.1.0, the syntax is ~>1.0.2.

@moolitayer
Copy link
Collaborator

moolitayer commented Mar 5, 2017

Fixes #230 [PR can't fix itself :)]

😄

LGTM on ~> not hardcoding minor version.
If the fixes in 1.0.2 are desirable, why not require at least 1.0.2?

Unless there is a specific problem you think we should mitigate, using ~> 1.0.0 would give us the latest available version and also not break users that have a = 1.0.0 dependency on ROS in their project

BTW do we want to stop before 1.1.0 or before 2.0.0? If they follow semver, 1.y.z should all be backward-compatible, but with this rate of releases, just covering 1.0.z is fine and safer.

👍 for not assuming minor version won't break us.

@simon3z simon3z merged commit 7e957ac into ManageIQ:master Mar 6, 2017
cben pushed a commit to cben/kubeclient that referenced this pull request Jan 22, 2018
…ent_on_recursive-open-struct

relax requirement on recursive-open-struct
cben pushed a commit to cben/kubeclient that referenced this pull request Jan 25, 2018
…ent_on_recursive-open-struct

relax requirement on recursive-open-struct
moolitayer pushed a commit to moolitayer/kubeclient that referenced this pull request Feb 4, 2018
…ent_on_recursive-open-struct

relax requirement on recursive-open-struct

(cherry picked from commit 7e957ac)
moolitayer pushed a commit to moolitayer/kubeclient that referenced this pull request Feb 4, 2018
…ent_on_recursive-open-struct

relax requirement on recursive-open-struct

(cherry picked from commit 7e957ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relax requirement on recursive-open-struct
4 participants