Introduce Kubeclient::ResourceNotFoundError

lib/kubeclient.rb

@@ -3,6 +3,7 @@
 require 'rest-client'
 require 'kubeclient/entity_list'
 require 'kubeclient/http_error'
+require 'kubeclient/resource_not_found_error'
 require 'kubeclient/watch_notice'
 require 'kubeclient/watch_stream'
 require 'kubeclient/common'

lib/kubeclient/common.rb

@@ -104,7 +104,8 @@ def handle_exception
         {}
       end
       err_message = json_error_msg['message'] || e.message
-      raise Kubeclient::HttpError.new(e.http_code, err_message, e.response)
+      error_klass = e.http_code == 404 ? ResourceNotFoundError : HttpError
+      raise error_klass.new(e.http_code, err_message, e.response)
     end
 
     def discover

lib/kubeclient/resource_not_found_error.rb

@@ -0,0 +1,4 @@
+module Kubeclient
+  class ResourceNotFoundError < HttpError
+  end
+end

test/test_guestbook_go.rb

@@ -45,8 +45,7 @@ def test_create_guestbook_entities
 
   def delete_namespace(client, namespace_name)
     client.delete_namespace(namespace_name)
-  rescue Kubeclient::HttpError => exception
-    assert_instance_of(Kubeclient::HttpError, exception)
+  rescue Kubeclient::ResourceNotFoundError => exception
     assert_equal(404, exception.error_code)
   end
 
@@ -89,8 +88,7 @@ def delete_services(client, namespace, services)
           # it's just a string - service name
           client.delete_service(service, namespace)
         end
-      rescue Kubeclient::HttpError => exception
-        assert_instance_of(Kubeclient::HttpError, exception)
+      rescue Kubeclient::ResourceNotFoundError => exception
         assert_equal(404, exception.error_code)
       end
     end
@@ -106,8 +104,7 @@ def delete_replication_controllers(client, namespace, replication_controllers)
           # it's just a string - rc name
           client.delete_replication_controller(rc, namespace)
         end
-      rescue Kubeclient::HttpError => exception
-        assert_instance_of(Kubeclient::HttpError, exception)
+      rescue Kubeclient::ResourceNotFoundError => exception
         assert_equal(404, exception.error_code)
       end
     end

test/test_kubeclient.rb

@@ -176,11 +176,10 @@ def test_nonjson_exception
 
     client = Kubeclient::Client.new('http://localhost:8080/api/', 'v1')
 
-    exception = assert_raises(Kubeclient::HttpError) do
+    exception = assert_raises(Kubeclient::ResourceNotFoundError) do
       client.get_services
     end
 
-    assert_instance_of(Kubeclient::HttpError, exception)
     assert(exception.message.include?('Not Found'))
     assert_equal(404, exception.error_code)
   end