Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): update deps #66

Merged
merged 2 commits into from
Jul 5, 2022
Merged

chore(all): update deps #66

merged 2 commits into from
Jul 5, 2022

Conversation

Malinskiy
Copy link
Owner

No description provided.

@Malinskiy Malinskiy force-pushed the feature/update-deps branch from 8c4b4a1 to 540f1cc Compare July 5, 2022 03:59
@hannesa2
Copy link
Contributor

hannesa2 commented Jul 5, 2022

I guess the double builds will disappear with #61

@hannesa2
Copy link
Contributor

hannesa2 commented Jul 5, 2022

Why not merge these in advance ?

image

These at least work.

But nice, you try to update this repository 👍

@Malinskiy
Copy link
Owner Author

Malinskiy commented Jul 5, 2022

The double builds are happening as a result of running for the tip of the branch (push) and the HEAD with the merged output from the target branch and the proposed change. That's intended and can be read as does it work on it's own and does it work if we merge it

@hannesa2
Copy link
Contributor

hannesa2 commented Jul 5, 2022

The double builds are happening as a result of running for the tip of the branch (push) and the HEAD with the merged output from the target branch and the proposed change. That's intended and can be read as does it work on it's own and does it work if we merge it

Maybe.
At least my fork removed the twice (and non-necessary) builds hannesa2#17 by containing #61

The (push) builds are pointless here

@Malinskiy
Copy link
Owner Author

I'm not forcing you to use any setup, I just explained why there are 2 builds and how they're different. If you navigate in the logs for the two builds you'll see for example
push:

HEAD is now at b387257 fix(all): update to TS4 for try-catch

pull_request:

HEAD is now at 2d8b051 Merge b387257f9eacad41055a74293f684ae388ac3aa7 into a8b313748036a9def32ed17cebceb932206bd74c

There is a case where only one of them fail

@Malinskiy Malinskiy merged commit 50f3fea into master Jul 5, 2022
@Malinskiy Malinskiy deleted the feature/update-deps branch July 5, 2022 05:41
@Malinskiy Malinskiy mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants