Merge latest changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A popular regexp implementation of Rust does not allow empty alternations.
The current Android 9 user agent is as follows Mozilla/5.0 (Linux; Android 9; Pixel Build/PPP3.180510.008) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.81 Mobile Safari/537.36 This commit allows the code to parse 9 as a valid OS version.
Added tests
The additional spaces may cause IDEs (specifically IntelliJ in my case) to transform this into a tab character. As a result of this, Java can not properly parse the YAML file, and every look up throws the following exception `org.yaml.snakeyaml.scanner.ScannerException`. By placing the comment on the expected level, parsing works as intended
add support for mac os detection when agent is macoutlook
Add support for patch_minor when detecting Chrome.
Update Android Regex to allow for single digit OS versions
Add support for Whale browser
Fixed Google Pixel detection
Fix indenting in regexes.yaml
Added test
handle single digit android versions
test single digit android versions
Update Salesforce to handle single digit android versions
Updated Facebook detection for user-agents without FBAV version
Add parser for Citrix Chrome app on Chrome OS
Fix #271: add Google user-agent on iOS
Handle useragents that present Windows 10
Added Snapchat detection
split windows 8.1 version
Add @commenthol to maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.