Use versionless Qt cmake targets #165
Conversation
|
This replaces #163 |
|
I guess the build pipeline uses 5.12 so this won't work. I think the solution is to add a job for a newer platform for both Qt 5.15 and Qt 6. I don't think it's a good idea to end support for the current 5.12 build yet. |
|
On second thought, I guess it doesn't make sense to make this simplification until the build only supports 5.15+ - hmmm, maybe I'll just do that soonish. Anyone needing the old compatibility would likely be able to use an old tag more easily than a dev with newer Qt toolchains installed that is actively trying to add or modify something. |
|
I don't think this should be hurried. It is simply a change that took place in Qt and makes sense to adopt whenever the sw is ready to force minimum compatibility with Qt 5.15. Let's not hurry. This pr will be open for whenever the sw is ready to do the jump in required version. Thanks :) |
|
Just for future reference one may find the available qt versions of different platforms in: At the time of writing this comment, the only platforms that do not yet ship Qt 5.15 are: |
## [0.53.2](Mahlet-Inc/hobbits@v0.53.1...v0.53.2) (2022-06-08) ### Bug Fixes * correctly display kaitai value instances for [Mahlet-Inc#145](Mahlet-Inc#145) ([556514b](Mahlet-Inc@556514b)) * fix kaitai plugin byte and string array sizes ([fdc2b10](Mahlet-Inc@fdc2b10))
## [0.53.3](Mahlet-Inc/hobbits@v0.53.2...v0.53.3) (2023-02-17) ### Bug Fixes * add prod build action and force a minor version bump ([4be6f45](Mahlet-Inc@4be6f45))
## [0.53.4](Mahlet-Inc/hobbits@v0.53.3...v0.53.4) (2023-02-17) ### Bug Fixes * update the semantic release config and force a release ([59f69f5](Mahlet-Inc@59f69f5))
# [0.54.0](Mahlet-Inc/hobbits@v0.53.4...v0.54.0) (2023-02-17) ### Features * add Edit plugin ([9c091e5](Mahlet-Inc@9c091e5))
antoniovazquezblanco
force-pushed
the
dev/qtver
branch
from
9fc60ac to
3d7a768
Compare
|
@hello-adam how are you doing? It seems there is not much movement regarding hobbits. It's been almost a year and no functionality seems to get pushed. I guess that this means that making hobbits Qt6 compatible can help package maintainers while not punishing users. How do you feel about going Qt versionless with Qt > 5.15 minimum requirement now? Thanks! |
|
Thanks for the reminder! I'll set up a newer build environment and give this another shot. I've also noticed that the released *.deb package doesn't find the plugins correctly, so I'll try to fix that as well while I'm at it. |
|
🎉 This PR is included in version 0.54.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
seemed to work fine, thanks a bunch @antoniovazquezblanco |
|
Thank you! |
Qt 5.15 introduced versionless package detection. In the future this may allow for Qt 5 & Qt6 compatibility.
https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html