Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control: NumericUpDown #846

Merged
merged 16 commits into from
Dec 7, 2013

Conversation

michaelmairegger
Copy link
Contributor

Implemented a NumericUpDown control.

Closes #841

@AzureKitsune
Copy link
Member

XAML looks fine. Everything looks fine except for one little thing. Custom controls like this go in the Themes folder instead of Styles (which is for styles for built-in WPF controls). It's a way of keeping things organized.

Other than that, I'll give it a small try and see how nice it is.

@AzureKitsune
Copy link
Member

img

The control is a good start. Is there a way we could make it look more like this: img from callisto?

@MahApps/contributors what do you think?

@michaelmairegger
Copy link
Contributor Author

Thanks for the feedback. I will move the style to the appropriate folder
Yes, I think that would be possible. I'ts more metro style. I will change it later today.

@michaelmairegger
Copy link
Contributor Author

Now it looks more like MahApps. I have added a trigger for MouseOver like it already exists for TextClearButton, ...
numericupdpwn

@AzureKitsune
Copy link
Member

That's awesome. Do the headers respond to 'FontSize'?

@michaelmairegger
Copy link
Contributor Author

What do you mean with header
_SmallChange="2"_ are only labels to indicate the properties that are set on the NumericUpDown below.

@AzureKitsune
Copy link
Member

Oh, yeah, never mind. I thought those labels were a part of the control, hence why I called them "header".

@MahApps/contributors Opinions?

@flagbug
Copy link
Member

flagbug commented Dec 7, 2013

👍

@AzureKitsune AzureKitsune mentioned this pull request Dec 7, 2013
15 tasks
@AzureKitsune
Copy link
Member

@xxMUROxx Let us know when you're finished so I can merge this.

@michaelmairegger
Copy link
Contributor Author

Yes, I have finished.

AzureKitsune added a commit that referenced this pull request Dec 7, 2013
@AzureKitsune AzureKitsune merged commit b4ac1e1 into MahApps:master Dec 7, 2013
@michaelmairegger michaelmairegger deleted the feature/NumericUpDown branch December 7, 2013 15:40
@michaelmairegger michaelmairegger restored the feature/NumericUpDown branch December 19, 2013 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants