[RFC] Removed DWM NCR attributes, added WindowChrome. Fixes #481, #488, #496. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DWM non-client rendering directly. Added http://archive.msdn.microsoft.com/WPFShell for MA.M .NET 4 client profile. Fixes #481, #488, #496.
|
well i tested you fork, i can run my windowsformhost :S |
|
Let me review this and see if we can do it without taking a dependency on Microsoft.Windows.Shell |
ghost
assigned 
|
There is a NuGet package, we could use that as dependency for a NET40 Mahapps.Metro package |
|
@flagbug Yeah, I use the NuGet package. I was worried about it being a dependency for people not using the NuGet package. |
|
So the source for this is distributed under MS-PL (the same license we use) so we could pull in just that class and avoid the whole "dependency" headaches. Stay tuned, will post more here and ensure everyone is happy with it. |
|
#503 has this change and other patches so that it is ready to publish - just a couple of minor things to sort out first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.