Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate report process #45

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

mavotto
Copy link
Contributor

@mavotto mavotto commented Jun 15, 2023

The ability to be able to process aggregate reports generated by Jacoco is added in this pr.
The functionality is enabled by setting aggregate-mode to true

fixes #40

@mavotto mavotto force-pushed the add-aggregate-report-process branch from 7ae1af3 to 5631ebf Compare June 15, 2023 10:43
@thsaravana thsaravana self-requested a review July 21, 2023 18:27
@thsaravana thsaravana self-assigned this Jul 21, 2023
@thsaravana thsaravana modified the milestones: 1.3, 1.6, 1.5 Jul 21, 2023
action.yml Outdated
@@ -26,6 +26,10 @@ inputs:
description: "Run the action in debug mode and get debug logs printed in console"
required: false
default: "false"
aggregate-mode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this?
I yet to try configuring "jacoco-playground" repo to generate aggregated report. But from your test cases, I saw the XML of the generated file. Can't we just check for the presence of "" and then figure out it's in aggregate-mode?

Copy link
Member

@thsaravana thsaravana Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DTD for the jacoco report xml, we have "<group>" which the github-action currently doesn't support. I will use your PR to add support for that. I am going to remove the "aggregate-mode" flag, and keep the rest.

@thsaravana thsaravana merged commit 6e2d264 into Madrapps:main Jul 22, 2023
@thsaravana
Copy link
Member

The DTD is not fully supported. There are still cases like "group can exist within group", "report can contain both group and package"...
I will add the full DTD support along with the Multi Module support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of support for multi module aggregated raports
2 participants