Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip on no changes option #33

Merged
merged 6 commits into from
Jul 22, 2023
Merged

Add skip on no changes option #33

merged 6 commits into from
Jul 22, 2023

Conversation

imbyungjun
Copy link
Contributor

Hi,
I'm using jacoco-report action well, but I need a simple option, so I made a PR.

I wish I could skip adding a comment if the file coverage is not changed.
So, I added a simple option skip-on-no-changes.

In my case, use jacoco-report action multiple times to get coverage for each modules like..

- name: A Coverage
  uses: madrapps/[email protected]
  with:
    title: "A Coverage"
    paths: ${{ github.workspace }}/module-A/build/reports/jacoco/testCoverage/testCoverage.xml
    ...

- name: B Coverage
  uses: madrapps/[email protected]
  with:
    title: "B Coverage"
    paths: ${{ github.workspace }}/module-B/build/reports/jacoco/testCoverage/testCoverage.xml
    ...

It makes to add all the comments for each modules even if there's no file coverage changed on a module.
If the skip-on-no-changes option is available, a module that file coverage is not changed can be out of PR context by skipping to add a comment.

@thsaravana thsaravana added this to the 1.5 milestone May 31, 2023
@thsaravana thsaravana self-assigned this Jul 21, 2023
@thsaravana thsaravana self-requested a review July 22, 2023 07:40
@thsaravana thsaravana merged commit 2e0c7d5 into Madrapps:main Jul 22, 2023
@thsaravana
Copy link
Member

@imbyungjun Thank you for PR. I am working on adding native multi-module support. So probably I might tweak the behavior of this flag a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants