bug fixes + readme #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaHryCT3
reviewed
Jul 16, 2024
| @@ -9,7 +9,7 @@ | |||
| def get_member_locale(member: discord.Member, raise_exception: bool = False) -> LocaleEnum | None: | |||
| roles_map = DynamicSettings().locale_roles | |||
| for role in member.roles: | |||
| if role.id in roles_map: | |||
| if role and role.id in roles_map: | |||
There was a problem hiding this comment.
тут подпиши, что if role, это проблема либы, что там бывает None приходит
MaHryCT3
reviewed
Jul 16, 2024
| @@ -43,7 +43,7 @@ def cast_func(setting_value: dict): | |||
|
|
|||
|
|
|||
| class DynamicSettings(metaclass=Singleton): | |||
| find_friend_cooldown: int = SettingValue() | |||
| find_friend_cooldown: int = SettingValue(default_factory=int) | |||
There was a problem hiding this comment.
вроде еще хотели же обязательным сделать поле default_factory
There was a problem hiding this comment.
на сколько я помню проблема в том что тупа не ставится значение параметру
может просто по умолчанию даже None ставить
|
а еще можешь избавиться от Singleton, просто создай в этой же файле инстанс и пусть лучше он импортится по всем файликам |
An3loN
force-pushed
the
dev
branch
3 times, most recently
from
c7029d9 to
2675e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guild_only -> contexts
new chapter about bot setup in readme
bug fixes
dependencies updated