New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new release #70

Merged

engdorm merged 2 commits into main from dev

May 15, 2023

Contributor

engdorm commented May 14, 2023 •

edited by jira bot

Loading

BP-996: Not possible to upload assets to Package
- The package model was imported from the new models
  while the classes repo imported from the deprecated dir (inherit from scopes)
  
  And while running the Package.add() function it raises NotImplementedError
  
  as we can see:
  https://github.com/MOV-AI/data-access-layer/blob/feature/BP-255/intergrating-the-spawner/dal/models/package.py#L41
  
  in the new model (inherit from the model) this function raises this exception

Dor.M and others added 2 commits

May 10, 2023 11:56


          correct the import of the package

e739464


          Merge pull request #69 from MOV-AI/bugfix/BP-996/cant-upload-package

e63043d

correct the import of the package

engdorm requested review from erezz-mov-ai and Mograbi

May 14, 2023 08:13

engdorm self-assigned this

sonarqubecloud bot commented May 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Mograbi approved these changes

View reviewed changes

engdorm merged commit 2c2c63e into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet