fix(prt): record user tracking times for stationary particles #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking time with termination event
There was a problem hiding this comment.
Since these checks are based on the particle being in a cell that can be wet or dry, would it be more appropriate to put them in a lower-level Method subclass (at the Grid level or below)? Thinking that someday we'll likely have methods for particle tracking through other kinds of models/grids/features, and they might not use these particular cell-based checks
There was a problem hiding this comment.
Will do some refactoring per these considerations in a separate PR.
|
It's tricky to get particle management and reporting right. Should test more thoroughly and encapsulate state manipulation and transitions where we can in type-bound procedures on the particle, store and methods.. |
wpbonelli
added a commit
that referenced
this pull request
Jan 31, 2025
Reporting was incorrect for permanently unreleased particles. We want to report them once when they were scheduled for release. #2177 fixed an issue where they were reported every time step, but the solution was incorrect, only reporting them if the release occurred in the first time step. Also fix reporting for timed-out particles. The new status code 10 introduced by #2177 covers not only the simulation ending but the particle reaching its stop time as well. Update some comments and notes too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2172 and other problems affecting tracking events, in context of the DRY_TRACKING_METHOD STAY option and more generally.
1-4 are only relevant/possible with newton on.
Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettify