Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fmi): support binary grid file #2153

Merged
merged 21 commits into from
Jan 25, 2025

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jan 20, 2025

Support an optional GWFGRID entry in FMI for the flow model's binary grid file. If provided, check the grids have the same size and idomain like we do in EXG as of #2149. This makes for the same error-checking in the exg (coupled) and fmi (post-processing) cases.

@langevin-usgs suggested making the grid file entry optional for some time (1-2 releases), then beginning to require it. At which point the reader could be modified to load the full dis, and we could consolidate these haphazard checks into a robust grid comparison as suggested by @mjr-deltares.

The grb file reader in zonebudget is moved to a new GridFileReader module in the main src dir. The reader now loads headers and builds an index at init time, after which variables can be read as necessary.


Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli force-pushed the fmi-check-idomain branch 2 times, most recently from ea517d1 to d3f49df Compare January 24, 2025 04:25
@wpbonelli wpbonelli changed the title feat(grb): add binary grid file reader, support grid file in fmi (WIP) feat(grb): add binary grid file reader, support grid file in fmi Jan 24, 2025
@wpbonelli wpbonelli changed the title feat(grb): add binary grid file reader, support grid file in fmi feat(grb): support grid file in fmi Jan 24, 2025
@wpbonelli wpbonelli changed the title feat(grb): support grid file in fmi feat(fmi): support binary grid file Jan 24, 2025
@wpbonelli wpbonelli marked this pull request as ready for review January 24, 2025 17:48
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wpbonelli wpbonelli added this to the 6.6.1 milestone Jan 24, 2025
@wpbonelli wpbonelli merged commit ccfe0e9 into MODFLOW-ORG:develop Jan 25, 2025
20 checks passed
@wpbonelli wpbonelli deleted the fmi-check-idomain branch January 25, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants