Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prt-prp): require exit solve tolerance option #1816

Merged
merged 3 commits into from
May 17, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented May 17, 2024

  • make EXIT_SOLVE_TOLERANCE required for DISV grids for all grids, motivation: one should be aware the generalized method is semi-analytical and subcells are solved numerically for grid cells we can't solve with Pollock's method
  • accept any value for DIS grids, following convention in e.g. rnb in gwf-csub.dfn packagedata where a sometimes-required option can have any value when not required

wpbonelli pushed a commit to wpbonelli/modflow6-examples that referenced this pull request May 17, 2024
@wpbonelli wpbonelli marked this pull request as ready for review May 17, 2024 17:00
@wpbonelli wpbonelli merged commit b50af44 into MODFLOW-ORG:develop May 17, 2024
1 of 6 checks passed
@wpbonelli wpbonelli deleted the require-tol branch May 17, 2024 21:08
wpbonelli added a commit to MODFLOW-ORG/modflow6-examples that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant