Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dist): multiple fixes following review #1573

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jan 24, 2024

  • omit utils/idmloader/ subdir
  • expand distribution checks per above
  • rerun mf6ivar.py to update mf6io files
  • fix typo in gwf-maw.dfn (missing "and")
  • use latex-friendly quotes in gwf-rcha.dfn
  • thanks to @rbwinst-usgs for raising issues

* omit utils/idmloader subdir
* update distribution checks
* rerun mf6ivar.py to update mf6io files
* fix typo in gwf-maw.dfn (missing and)
@wpbonelli wpbonelli marked this pull request as ready for review January 24, 2024 20:09
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only possible issue is the non-ASCII double quotes mentioned offline.

@wpbonelli wpbonelli merged commit 5aefebf into MODFLOW-ORG:develop Jan 24, 2024
15 checks passed
@wpbonelli wpbonelli deleted the dist branch January 24, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants