Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style check test (flake8) #25

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Add style check test (flake8) #25

merged 5 commits into from
Aug 26, 2022

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Aug 26, 2022

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Testing This is for testing features, writing tests or producing testing code label Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #25 (b996146) into master (f2d5742) will not change coverage.
The diff coverage is 87.50%.

❗ Current head b996146 differs from pull request most recent head 451713e. Consider uploading reports for the commit 451713e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files          13       13           
  Lines        1042     1042           
=======================================
  Hits          942      942           
  Misses        100      100           
Impacted Files Coverage Δ
nigsp/objects.py 100.00% <ø> (ø)
nigsp/operations/metrics.py 100.00% <ø> (ø)
nigsp/operations/timeseries.py 92.47% <66.66%> (ø)
nigsp/io.py 91.12% <100.00%> (ø)
nigsp/operations/laplacian.py 100.00% <100.00%> (ø)
nigsp/operations/nifti.py 96.55% <100.00%> (ø)
nigsp/operations/surrogates.py 89.91% <100.00%> (ø)
nigsp/utils.py 95.12% <100.00%> (ø)

@smoia smoia merged commit 8914ac9 into MIPLabCH:master Aug 26, 2022
@smoia smoia deleted the int/linttest branch August 26, 2022 12:08
@smoia smoia added the Released This PR has been released! label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released This PR has been released! Testing This is for testing features, writing tests or producing testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant